Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tooltip bug when unchecking a curve on multi-charts #2199

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Jan 20, 2025

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Related to the topic https://community.gladysassistant.com/t/loss-of-values-if-you-uncheck-a-data-thread/9306
image

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (04c1528) to head (d2edcfa).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2199   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14436    14436           
=======================================
  Hits        14225    14225           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jan 20, 2025

#2957 Bundle Size — 10.41MiB (~+0.01%).

d2edcfa(current) vs 04c1528 master#2952(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2957
     Baseline
#2952
Regression  Initial JS 5.64MiB(~+0.01%) 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
No change  Cache Invalidation 54.07% 54.07%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2957
     Baseline
#2952
Regression  JS 7.43MiB (~+0.01%) 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:fixed-tooltip-bug-when-...Project dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles
Copy link
Contributor

Thanks for your PR ! I merged this PR in mine:

#2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants