-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /geyser connectiontest
command usage
#299
Merged
rtm516
merged 6 commits into
GeyserMC:master
from
onebeastchris:connection_test_command_change
Aug 1, 2024
Merged
Update /geyser connectiontest
command usage
#299
rtm516
merged 6 commits into
GeyserMC:master
from
onebeastchris:connection_test_command_change
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtm516
approved these changes
Nov 1, 2023
Konicai
reviewed
Nov 1, 2023
src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Outdated
Show resolved
Hide resolved
remove timestamp, changed title
Konicai
reviewed
Jul 9, 2024
src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Outdated
Show resolved
Hide resolved
…on_test_command_change # Conflicts: # src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Konicai
approved these changes
Jul 9, 2024
Konicai
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh oops
Chew
previously requested changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting change for the setMaxLength thing, but the other comment is for discussion
src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Olivia <[email protected]>
2 tasks
Konicai
approved these changes
Aug 1, 2024
rtm516
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the cloud PR is merged, the
/geyser connectiontest
command will take in ip and port as separate args as opposed to them being separated by:
. This adapts the documentation to the change.Additionally, this also changes the
!ping
or/ping
command to work the same way - the port being an optional argument.