Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /geyser connectiontest command usage #299

Merged

Conversation

onebeastchris
Copy link
Member

After the cloud PR is merged, the /geyser connectiontest command will take in ip and port as separate args as opposed to them being separated by :. This adapts the documentation to the change.

Additionally, this also changes the !ping or /ping command to work the same way - the port being an optional argument.

…on_test_command_change

# Conflicts:
#	src/main/java/org/geysermc/discordbot/commands/PingCommand.java
Copy link
Member

@Konicai Konicai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh oops

Chew
Chew previously requested changes Jul 10, 2024
Copy link
Member

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change for the setMaxLength thing, but the other comment is for discussion

Co-authored-by: Olivia <[email protected]>
@Chew Chew dismissed their stale review July 10, 2024 20:35

The reason I requested a review was resolved

@rtm516 rtm516 merged commit d1027dd into GeyserMC:master Aug 1, 2024
1 check passed
@onebeastchris onebeastchris deleted the connection_test_command_change branch August 1, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants