Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4159: Increase textfields maxlength #4168

Closed

Conversation

stefan-korn
Copy link
Contributor

fixes #4159

  • Test coverage exists
  • Documentation exists

QA Steps

  • textfields have maxlength of 256 instead of 128 previously

@stefan-korn
Copy link
Contributor Author

see #4159 : Currently this is not a complete solution provided in this PR.

Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-korn I am ok with having this not work with array/object helper quite yet, but as implemented this will only be applied if there is something in the UI schema for the field in question; if you don't have an entry in your .ui.json file for the field it won't get the maxlength. I think it needs to at least work on things like title field even if there is no customization via the UI schema. I'm going to try to come at this in another way as I do need this to work for another project.

@dafeder dafeder mentioned this pull request Jul 2, 2024
6 tasks
@dafeder
Copy link
Member

dafeder commented Jul 2, 2024

Closing in favor of #4212

@dafeder dafeder closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase textfields maxlength
2 participants