Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4134: Datasets view should only list nodes of type Data #4135

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

stefan-korn
Copy link
Contributor

fixes #4134

  • Test coverage exists
  • Documentation exists

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform to confirm that the feature or fix is working. Include as much details as possible so that the reviewer doesn't lose time figuring out how to perform steps.

@stefan-korn
Copy link
Contributor Author

I suppose the test failed because it uses Drupal 10.0.x and the "settings.tooltip" was introduced to the schema in 10.1.x.

@paul-m
Copy link
Contributor

paul-m commented Feb 22, 2024

Nice catch. Add the following to those two tests, and they'll pass:

  /**
   * @todo Remove this when we drop support for Drupal 10.0.
   */
  protected $strictConfigSchema = FALSE;

Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and the changes fix the issue.

@paul-m paul-m changed the title #4134: View DKAN Metastore (Datasets) should only list nodes of type … #4134: Datasets view should only list nodes of type Data Feb 23, 2024
@paul-m paul-m merged commit 126d1e5 into GetDKAN:2.x Feb 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View DKAN Metastore (Datasets) should only list nodes of type Data
2 participants