Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile improvements #3567

Merged
merged 8 commits into from
Jul 21, 2021
Merged

Jenkinsfile improvements #3567

merged 8 commits into from
Jul 21, 2021

Conversation

grugnog
Copy link
Member

@grugnog grugnog commented Jul 19, 2021

fixes 3557

This should resolve the file ownership issues that occurred if DKAN Tools left files owned by root, skip builds for branches (PRs only) and a small amount of other cleanup.

@grugnog grugnog force-pushed the chown-pr branch 3 times, most recently from 496c9c6 to 6113039 Compare July 20, 2021 01:12
@grugnog
Copy link
Member Author

grugnog commented Jul 21, 2021

This depends on GetDKAN/dkan-tools#298 (and optionally GetDKAN/dkan-tools#297)

@dafeder dafeder requested a review from dasumner July 21, 2021 17:40
@dasumner dasumner merged commit 2422c76 into 2.x Jul 21, 2021
@dasumner dasumner deleted the chown-pr branch July 21, 2021 18:03
clayliddell pushed a commit that referenced this pull request Jul 26, 2021
* Always chown on job completion so that subsequent jobs can clean workspace.

* Switch to builds for PRs only.

* Need actual script.

* Check directory exists before getting commit message.

* Cleaner fix.

* Remove unneeded function.

* Test no-proxy branch.

* No need to fail if no proxy net connection present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants