Issue 75: add stringClass attributes to FileSystem #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ZnCharacterStreamTests >> testUpToAllTwice is not ...
…testUpToAllTwice, so added utf8 encoded streams to #testUpToAll (and boom) also updated #testUpToAll samples to include strings from #testUpToAllTwice ... failing tests
…treamPosition to illustrate what I think should be a bug
…gStreamPosition
…on test for completeness, reorder the samples in ZnCharacterStreamTests >> testUpToAll and fix some regressions that snuck in while working on utf8 variant
…aracterReadStream and ZnCharacterReadWriteStream, needed to allow end user to choose between Unicode and Legacy stream flavors
…Tests so we can test ZnCharacterStream with Unicode7 and String stringClass
…issues; testUpTo and testUpToAll tests are still not passing
…reamTests and ZnLegacyCharacterStreamTests: testUpToAll, testUpToAllTwice and testUtf8EncodingStreamPositionFor...) are all apparently due to Issue #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #75. ZnCharacterEncoder, ZnCharacterReadStream, and ZnCharacterReadWriteStream take stringClass (String or Unicode7) as a parameter for determining the type of strings created when decoding UTF8 or 8BIT files...
There are a set of failing tests that are waiting for a fix to issue #80.