Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest installing and using Mozart via composer.json #35

Merged
merged 3 commits into from
Jan 10, 2018

Conversation

coenjacobs
Copy link
Contributor

This suggests using the coenjacobs/mozart package to automatically rewrite the class to use a prefix in order to prevent collisions with other plugins bundling the same class but in a different (non-compatible) version.

We've implemented it this way in our base plugin: Mindsize/wp-plugin-base#2 using this exact class (which is great btw, thank you!).

I've written a bunch of posts and documentation on this subject to further investigate before your merge, if you prefer:

@GaryJones GaryJones merged commit fddfb25 into GaryJones:develop Jan 10, 2018
@GaryJones
Copy link
Owner

@coenjacobs Thanks!

As an aside, I'm wondering if TGMPA may also benefit from this suggestion - we occasionally get Issues being opened to say that TGMPA is being used in both a plugin and a theme (or multiple plugins) that someone is using and is causing a conflict, and our response has always been to get the user (or we do it ourselves) to ask the theme and plugin authors to ensure they are using the latest version.
If you think Mozart would be useful there (I've not looked att he finer details of it yet), then please open a ticket on the TGMPA repo, and @jrfnl and myself can discuss it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants