chore: remove chart transaction account #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
force-pushed
the
remove-chart-transaction-account
branch
from
d3a2ffd to
5b41bdb
Compare
vindard
force-pushed
the
remove-chart-transaction-account
branch
3 times, most recently
from
7681cc6 to
8f21921
Compare
vindard
force-pushed
the
remove-chart-transaction-account
branch
from
8f21921 to
1073756
Compare
vindard
force-pushed
the
remove-chart-transaction-account
branch
from
1073756 to
7d6fc4f
Compare
bodymindarts
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE before #1248Description
Transaction accounts aren't tracked in the chart. They don't get a GL code, and are simply detail accounts for the control sub-account they fall under.
The
add_transaction_accountis a no-op after this PR with a note to tie it back to the chart by using some sort of aControlSubAccountentity representation to track member accounts added to it