Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #4722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

chore: fix some typos #4722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/api/src/services/kratos/auth-username-password-deviceid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export const AuthWithUsernamePasswordDeviceIdService =

await kratosAdmin.createIdentity({ createIdentityBody })
} catch (err) {
// we continue if there is 409/Conflit,
// we continue if there is 409/Conflict,
// because it means the identity already exists
if (isAxiosError(err) && err.response?.status !== 409) {
return new UnknownKratosError(
Expand Down
2 changes: 1 addition & 1 deletion core/notifications/src/notification_event/price_changed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub struct PriceChanged {

impl PriceChanged {
const NOTIFICATION_THRESHOLD: ChangePercentage = ChangePercentage(5.0);
#[allow(deprecated)] // recommndation is try_days but Option.unwrap() is not yet const fn
#[allow(deprecated)] // recommendation is try_days but Option.unwrap() is not yet const fn
const COOL_OFF_PERIOD: chrono::Duration = chrono::Duration::days(2);

pub fn should_notify(&self, last_trigger: Option<chrono::DateTime<chrono::Utc>>) -> bool {
Expand Down
Loading