Reduce memory allocations #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR seems to have broken multiple icons within the config in beta 3, as well as the entire status effect hud. Previously a few textures from thaumcraft were used for the precipitation line (specifically the aspects tempestas, aqua, and gelum). Also, it appears that minecraft icons like for a slimeball and diamond pickage are also broken. Unsure what was changed in this PR that caused these textures to break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#17152
This turns this mod from a memory guzzling beast as seen in GTNewHorizons/GT-New-Horizons-Modpack#15537 into a gentle little creature with a fraction of the allocations used previously. The amount of things that it allocated constantly was truly absurd and completely unnecessary,
Everything looks more or less the same but testing is definitely needed to weed potential issues.
Screenshot is from dev and is thus missing some icons from other mods