Use static block initialization for better compatibility #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneEyeMaker
approved these changes
Apr 4, 2024
eigenraven
requested changes
Apr 4, 2024
| */ | ||
| public static void init() { | ||
| static { | ||
| // Initialize the blocks of this mod | ||
| SpaceElevatorCable = new BlockSpaceElevatorCable(); | ||
| GameRegistry.registerBlock(SpaceElevatorCable, ItemBlockSpaceElevatorCable.class, "spaceelevatorcable"); |
There was a problem hiding this comment.
This is a bad idea imo, registration should be called from this mod's preinit and this will cause the first class load try to register the blocks, which might happen in another mod
There was a problem hiding this comment.
If something needs the blocks from this mod, it should use a after: or required-after: dependency in its @Mod annotation to ensure the blocks are registered in time
Dream-Master
added
ongoing freeze - don't merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes explicit initializers are not called in time, which may improve the compatibility of this mod.