Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cells for missing coremod fluids #3774

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Add cells for missing coremod fluids #3774

merged 3 commits into from
Jan 10, 2025

Conversation

serenibyss
Copy link
Member

Gelatin Mixture, Meat Extract, Radox Gas, Diluted Xenoxene

Gelatin Mixture, Meat Extract, Radox Gas, Diluted Xenoxene
@serenibyss serenibyss requested a review from a team January 10, 2025 01:52
@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Jan 10, 2025
@Glease
Copy link
Contributor

Glease commented Jan 10, 2025

Just curious, why do you decide to mix these constants among the existing elements in a semi random order? not that it matters, but it's slightly weird..

@serenibyss
Copy link
Member Author

Just curious, why do you decide to mix these constants among the existing elements in a semi random order? not that it matters, but it's slightly weird..

The IDs were super out of order already, so I just organized the fluids more with their related fluids rather than trying to fix the order. The comment at the top should hopefully make it clear for new PRs adding anything

@serenibyss serenibyss enabled auto-merge (squash) January 10, 2025 17:17
@serenibyss serenibyss merged commit 689542a into master Jan 10, 2025
5 checks passed
@serenibyss serenibyss deleted the missing-fluid-cells branch January 10, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants