Apply correct EU modifier for calculating parallels in the Volcanus. #3754
Conversation
|
@Vlamonster |
Dream-Master
added
the
🚧 Testing on Zeta
| .setEUtModifier( | ||
| euModifier | ||
| * Math.pow(0.95F, Math.floor((getCoilLevel().getHeat() - recipe.mSpecialValue) / 900F))) |
There was a problem hiding this comment.
I believe this is now applying the heat EU/t discount twice (before and after parallel). Currently it seems like every machine that does a heat EU/t discount does this discount after parallel. This isn't necessarily a "bug," but a decision we need to make whether this discount should be applied before or after. If we decide to change it to before though, it should be changed deeper down in processinglogic rather than in a machine implementation like this
There was a problem hiding this comment.
This behavior exists in all other machines afaik, and we only noticed a difference in the Volcanus because we use a spreadsheet to calculate overclocks for all machines up to UMV.
There was a problem hiding this comment.
This is not the behavior of other machines with heat discounts, MEBF, EBF, Vacuum Furnace, Gorge EBF modules all use similar heat discount mechanics but do not double apply like this
There was a problem hiding this comment.
What do you mean by double apply? It doesn't provide a double discount if that's what you're referring to. It just makes it so that it uses all available energy for parallels, i.e. if it can do another parallel then it will.
There was a problem hiding this comment.
The heat discount is applied during overclock calculation, here
As said in the Java docs of OverclockCalculator#setHeatDiscount, "Sets if we should add a heat discount at the end of calculating an overclock, just like the EBF." Volcanus does this discount after parallels during overclock, like EBF, MEBF, etc. so by adding this discount here you are doing this heat discount twice, once before parallel and once after.
Furthermore, if this change is to be accepted, the heat discount should be applied before parallel internally, instead of needing to do a hack like this PR. Though this needs discussion
Resolved issue #17399.