Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Biovat and Radio Hatches #3728

Merged
merged 25 commits into from
Jan 11, 2025
Merged

Conversation

StaffiX
Copy link
Contributor

@StaffiX StaffiX commented Dec 29, 2024

  • Made bio vat recipes use metadatas entirely.
  • Moved radio hatch recipemap to an arraylist since it used duration data for mass and eu/t data for sievert and reused the existing recipemap to a fake recipemap to display it in NEI.
  • Removed capacity limit from HV radio hatch, and deprecated rest of the tiers
    image
    image
    Some materials had mass that are higher than the best (UV) radio hatch has (The Core is 96kg, but you can only store 6kg in it, so this would allow to actually use them.
  • This also fixes Radio Hatch Constant Sv GT-New-Horizons-Modpack#18061

@StaffiX StaffiX added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Dec 29, 2024
@StaffiX StaffiX marked this pull request as draft December 29, 2024 19:18
@StaffiX StaffiX marked this pull request as ready for review December 29, 2024 21:26
@StaffiX StaffiX added the bug fix Fix a bug. Please link it in the PR. label Dec 29, 2024
@Dream-Master Dream-Master requested a review from a team December 29, 2024 22:33
@Dream-Master Dream-Master requested a review from a team December 30, 2024 18:20
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 30, 2024
@serenibyss serenibyss enabled auto-merge (squash) January 11, 2025 08:10
@serenibyss serenibyss merged commit 6fa0969 into GTNewHorizons:master Jan 11, 2025
5 checks passed
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 11, 2025
@StaffiX StaffiX deleted the biovat branch January 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR. refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio Hatch Constant Sv
3 participants