Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cribs super recipe check #3608

Merged

Conversation

lordIcocain
Copy link
Contributor

@lordIcocain lordIcocain commented Dec 6, 2024

Get pattern inputs
Find recipes in this machine recipe map
Save recipes in processingLogic using HashMap and slot.getHash() as key.
Machine recipe check will search for recipes in Map using slot.getHash() as key then performe recipeCheck for this single recipe.

Should improve endgame bases performance.

@chochem chochem added ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. labels Dec 6, 2024
@Dream-Master Dream-Master requested a review from a team December 7, 2024 21:51
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master
Copy link
Member

@lordIcocain can you run spotless

@lordIcocain
Copy link
Contributor Author

Done

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the idea of this PR is good, though the implementation could use refinement

@lordIcocain lordIcocain requested a review from miozune January 11, 2025 10:54
@Dream-Master Dream-Master requested a review from a team January 11, 2025 10:57
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Nice work!

@Dream-Master Dream-Master merged commit 79d4df8 into GTNewHorizons:master Jan 12, 2025
5 checks passed
@lordIcocain lordIcocain deleted the cribs_super_recipe_check branch January 12, 2025 16:31
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants