Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godforge encore #3213

Merged
merged 55 commits into from
Oct 3, 2024
Merged

Godforge encore #3213

merged 55 commits into from
Oct 3, 2024

Conversation

serenibyss
Copy link
Member

@serenibyss serenibyss commented Sep 17, 2024 •
edited
Loading

There's always at least one more PR than anticipated for a new feature

Closes GTNewHorizons/GT-New-Horizons-Modpack#17525
Closes GTNewHorizons/GT-New-Horizons-Modpack#17468

@serenibyss serenibyss added bug fix Fix a bug. Please link it in the PR. new feature Add something new. Please explain in detail how it works. labels Sep 17, 2024
@serenibyss
Fix windows relocating on reopen
180709d 
Requires GTNewHorizons/ModularUI#80 to function properly, but not to compile
GDCloudstrike and others added 20 commits September 27, 2024 23:56
@GDCloudstrike
fix fuel consumption rounding issues
071448b
@GDCloudstrike
fix items in material window disappearing after restart
b5e5407
@GDCloudstrike
rename infinity plasma to be consistent
25db96d
@Dream-Master
Merge branch 'master' into godforge-encore
b8a5184
@GDCloudstrike
disable hatch filtering on exotic module
bcb3b7b
@GDCloudstrike
fix autobuild rebuilding rings that already got absorbed
b7a1125
@GDCloudstrike
fix typos
0cd2f36
@GDCloudstrike
fix minor text oversight
88d8155
@serenibyss
fix e notation formatting on power milestone
36296a0
@serenibyss
cleanup + refactor milestone formatting
cb5d1df
@serenibyss
fix fuel config window textbox sync issues
4bcedc3
@GDCloudstrike
add red background
725a1fa
@serenibyss
restore post milestone hint text
b8c0285
@serenibyss
Fix structure tooltip detail
6dd3dbe 
Closes GTNewHorizons/GT-New-Horizons-Modpack#17468
@serenibyss
Merge branch 'master' into godforge-encore
6dbbd31
@serenibyss
add general info window to all modules
2513eb1
@serenibyss
center primary upgrade text in individual upgrade window
b865a34
@serenibyss
Merge branch 'master' into godforge-encore
8bb58b9
@serenibyss
Merge branch 'master' into godforge-encore
e12726d
@serenibyss
retexture celestial button bg
f29efcf
@serenibyss serenibyss marked this pull request as ready for review October 3, 2024 21:26
NotAPenguin0
NotAPenguin0 requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing I'm not sure about

src/main/java/tectech/thing/metaTileEntity/multi/godforge_modules/MTESmeltingModule.java Show resolved Hide resolved
@NotAPenguin0 NotAPenguin0 self-requested a review October 3, 2024 22:05
@serenibyss serenibyss enabled auto-merge (squash) October 3, 2024 22:08
@serenibyss serenibyss merged commit e16f7ac into master Oct 3, 2024
5 checks passed
@serenibyss serenibyss deleted the godforge-encore branch October 3, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotAPenguin0 NotAPenguin0 NotAPenguin0 approved these changes

@GDCloudstrike GDCloudstrike Awaiting requested review from GDCloudstrike

Assignees
No one assigned
Labels
bug fix Fix a bug. Please link it in the PR. new feature Add something new. Please explain in detail how it works.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some plasma missing recipes Gorge tooltip size mistake
4 participants
@serenibyss @NotAPenguin0 @GDCloudstrike @Dream-Master