Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise diagnostics only if activate extraction is set to true #29

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

dinatraykova
Copy link
Member

Fix issue with loading inner_r and outer_r variables.
They're only necessary if you want to extract the integrals of the diagnostic variables.

@dinatraykova dinatraykova requested a review from KAClough January 17, 2025 14:25
@KAClough
Copy link
Member

As discussed, let's give the user the ability to use the excision/volume extraction separately from the surface extraction. Otherwise it looks good!

@dinatraykova
Copy link
Member Author

As discussed, let's give the user the ability to use the excision/volume extraction separately from the surface extraction. Otherwise it looks good!

Separated into activate_extraction and activate_excision
Default of activate_excision set to activate_extraction
Moved all extraction params to FixedBGSimulationParametersBase.hpp

Copy link
Member

@KAClough KAClough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good!

@KAClough KAClough merged commit 9928bcd into main Jan 20, 2025
5 checks passed
@KAClough KAClough deleted the bugfix/activate_extraction branch January 20, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants