Added Generics to fn_name building to solve lifetimes issues #144
+162
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes regarding issue GREsau#84. Also added an example to showcase the behaviour
|
Thanks for the MR. Looks good, but will have to look at this when I have some more time so I can properly test this before merging. |
|
Hi, thanks! I use my fork of the project in a pretty last project for about 2 Month now without any problems. This only covers lifetimes. From my understanding generics should also be supported but I haven't tested that at all. |
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Generic parameters to fn_name to solve issues with named lifetimes regarding Issue #84.
Also added an example to showcase the behaviour