Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove using namespace #74

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Dec 12, 2023

Using namespace in headers is prone to generate conflicts, so specify the namespace explicitly.

Using namespace in headers is prone to generate conflicts, so specify
the namespace explicitly.
Copy link
Collaborator

@jasilvanus jasilvanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passing.

@jiaolu jiaolu merged commit 9e2ad76 into GPUOpen-Drivers:dev Dec 13, 2023
8 checks passed
@Flakebi Flakebi deleted the using-namespace branch December 13, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants