Add support for typed pointers with the builtin PointerType. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsymalla
force-pushed
the
typed_pointer_support
branch
2 times, most recently
from
355979a to
eb5c5c4
Compare
tsymalla-AMD
reviewed
Dec 1, 2023
tsymalla
force-pushed
the
typed_pointer_support
branch
from
eb5c5c4 to
f171e3b
Compare
In some scenarios, we want to use typed pointers even if LLVM is moving to opaque pointers. Dialects currently only supports opaque pointers in its builtin. With this change, we simply return an i8* when evaluating a builtin pointer type return value or operand. This translates to an opaque pointer as well. The client that creates the operations is responsible for handling the pointers correctly (e. g. not using opaque pointers in a typed pointer scenario).
tsymalla
force-pushed
the
typed_pointer_support
branch
from
f171e3b to
ad22fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenarios, we want to use typed pointers even if LLVM is moving to opaque pointers. Dialects currently only supports opaque pointers in its builtin. With this change, we simply return an i8* when evaluating a builtin pointer type return value or operand. This translates to an opaque pointer as well.
The client that creates the operations is responsible for handling the pointers correctly (e. g. not using opaque pointers in a
typed pointer scenario).