-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linuxarm64 #1400
Merged
Merged
Linuxarm64 #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What a tough adventure. Thanx for solving a murder mystery where the
detective was the murderer.
I know we sometimes get into legit edge cases where printf, <<, to_chars,
and such round in different allowable ways, but I'm always surprised at
what we get away with out in those sub-mm bits where we get exact matches
regardless if our double math is done on a 64 or 80 bit number and all the
different CPU types that we've been on on through the years. For example, I
never expected to just byte-swap a Dragonball double and have it
numerically preserveded on a contemporary system, but we've done
effectively that for quite some time now.
…On Wed, Jan 22, 2025 at 8:30 AM tsteven4 ***@***.***> wrote:
Add CI job to build and test on Linux arm64.
This ran into rounding errors in our regression tests with the igc format
and valgrind. The tests all passed without valgrind, but many of the igc
tests failed reference comparisons when run under valgrind. This failures
occur on arm64 with valgrind 3.22.0 and 3.23.0. They do not occur with
valgrind 3.24.0. See
https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/2095501
To work around this I created a ppa with valgrind 3.24.0:
https://launchpad.net/~tsteven4/+archive/ubuntu/valgrind-backports
------------------------------
You can view, comment on, or merge this pull request online at:
#1400
Commit Summary
- e386789
<e386789>
develop linux arm64 build
- f261680
<f261680>
add dependency
- 3438f87
<3438f87>
add dependency
- 81425e8
<81425e8>
try bleading edge vg
- 91190e9
<91190e9>
build vg
- 6b6da8e
<6b6da8e>
build vg harder
- eab4827
<eab4827>
vg
- 642c189
<642c189>
vg
- a15409b
<a15409b>
debug vg
- 84b5426
<84b5426>
try 3.23
- 3188888
<3188888>
debu
- 132aa21
<132aa21>
Revert "debug vg"
- 58c7599
<58c7599>
workaround vg issue
- 86530d6
<86530d6>
Revert "debu"
- cc1de3d
<cc1de3d>
use ppa for valgrind
- 1ed99ed
<1ed99ed>
Revert "use ppa for valgrind"
- b46cf9a
<b46cf9a>
try 3.23.0
- 8cac3cf
<8cac3cf>
Revert "try 3.23.0"
- d610164
<d610164>
Reapply "use ppa for valgrind"
- 2c7d397
<2c7d397>
use vg 3.24.0 from ppa
- 1cb2132
<1cb2132>
gather bug report info
- 4e95a9d
<4e95a9d>
Revert "gather bug report info"
- 8bd0b99
<8bd0b99>
update comment re valgrind bug.
File Changes
(1 file <https://github.com/GPSBabel/gpsbabel/pull/1400/files>)
- *M* .github/workflows/ubuntu.yml
<https://github.com/GPSBabel/gpsbabel/pull/1400/files#diff-6640e8c668a6deeb426558faaa2b0f535d95814c09a05c044a1df27a008dd544>
(27)
Patch Links:
- https://github.com/GPSBabel/gpsbabel/pull/1400.patch
- https://github.com/GPSBabel/gpsbabel/pull/1400.diff
—
Reply to this email directly, view it on GitHub
<#1400>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCSD37R4CQQALK6LMWUG7L2L6TPVAVCNFSM6AAAAABVVCQKWCVHI2DSMVQWIX3LMV43ASLTON2WKOZSHAYDINJUGU3TONY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI job to build and test on Linux arm64.
This ran into rounding errors in our regression tests with the igc format and valgrind. The tests all passed without valgrind, but many of the igc tests failed reference comparisons when run under valgrind. This failures occur on arm64 with valgrind 3.22.0 and 3.23.0. They do not occur with valgrind 3.24.0. See https://bugs.launchpad.net/ubuntu/+source/valgrind/+bug/2095501
To work around this I created a ppa with valgrind 3.24.0: https://launchpad.net/~tsteven4/+archive/ubuntu/valgrind-backports