Skip to content

Commit

Permalink
fix error in uploadtool (#1405)
Browse files Browse the repository at this point in the history
The error meant releases were always deleted, preventing
a second job from adding an asset to an existing release.
This use case is important now as we are generating snaps
for both amd64 and arm64.
  • Loading branch information
tsteven4 authored Jan 23, 2025
1 parent 0f98949 commit e9d6d4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/uploadtool/upload_github.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ echo "release_url: $release_url"
target_commit_sha=$(echo "$release_infos" | grep '"target_commitish":' | head -n 1 | cut -d '"' -f 4 | cut -d '{' -f 1)
echo "target_commit_sha: $target_commit_sha"

if [ "{$GITHUB_SHA}" != "$target_commit_sha" ] ; then
if [ "${GITHUB_SHA}" != "$target_commit_sha" ] ; then

echo "GITHUB_SHA != target_commit_sha, hence deleting $RELEASE_NAME..."

Expand Down

0 comments on commit e9d6d4b

Please sign in to comment.