AclCommentManager::saveComment must have a return value (#692)

* AclCommentManager::saveComment must have a return value * Fixed unit test
FriendsOfSymfony · Aug 22, 2019 · a4c05d7 · a4c05d7
1 parent b3589d0
commit a4c05d7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Acl/AclCommentManager.php b/Acl/AclCommentManager.php
@@ -130,11 +130,13 @@ public function saveComment(CommentInterface $comment)
             throw new AccessDeniedException();
         }
 
-        $this->realManager->saveComment($comment);
+        $state = $this->realManager->saveComment($comment);
 
-        if ($newComment) {
+        if ($state && $newComment) {
             $this->commentAcl->setDefaultAcl($comment);
         }
+
+        return $state;
     }
 
     /**

diff --git a/Tests/Acl/AclCommentManagerTest.php b/Tests/Acl/AclCommentManagerTest.php
@@ -227,6 +227,11 @@ public function testSaveComment()
              ->with($this->equalTo($this->comment))
              ->will($this->returnValue(true));
 
+        $this->realManager->expects($this->once())
+             ->method('saveComment')
+             ->with($this->equalTo($this->comment))
+             ->will($this->returnValue(true));
+
         $manager = new AclCommentManager($this->realManager, $this->commentSecurity, $this->threadSecurity);
         $manager->saveComment($this->comment, $this->parent);
     }