Update 'Only Show Latest Video for Each Channel' setting to handle a custom number of videos per channel

[c-ciobanu]

Update 'Only Show Latest Video for Each Channel' setting to handle a custom number of videos per channel

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #5265

Description

Updated the Only Show Latest Video for Each Channel setting to now handle a custom number of videos per channel to be shown.
Added a new variable to keep track of the number so the user can change it if the option is enabled.
I didn't change the existing setting so this way this feature is retro compatible.

Screenshots

simplescreenrecorder-2024-11-16_12.22.51.mp4

Testing

Enabled the feature and changed the number different times while checking that the Videos, Shorts, and Live tabs showed the correct amount of videos for each channel.

Desktop

• OS: Linux Mint
• OS Version: 21
• FreeTube version: 0.21.3

Additional context

I didn't remove the old localisation string, is it removed automatically or do I need to do it.

[kommunarr]

I haven't tested this yet, but good work! One potential suggestion: thoughts on having the label change to Limit the number of videos displayed for each channel to when the toggle is enabled and making the input an inline 2-digit-wide one? That way it could read out like a sentence.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I didn't remove the old localisation string, is it removed automatically or do I need to do it.

Its not automatically, you need to remove it.

[c-ciobanu]

I haven't tested this yet, but good work! One potential suggestion: thoughts on having the label change to Limit the number of videos displayed for each channel to when the toggle is enabled and making the input an inline 2-digit-wide one? That way it could read out like a sentence.

I personally prefer something like this:

to this:

Let me know what you think.

[c-ciobanu]

I didn't remove the old localisation string, is it removed automatically or do I need to do it.

Its not automatically, you need to remove it.

I imagine I have to remove it from all the files not just static/locales/en-US.yaml, right?

[kommunarr]

I personally prefer the latter (with a 1em horizontal margin), although either way is fine from a general styling standpoint as long as other contributors feel the same. My main concern is that if we were to add a new toggle to that column, it would be visually unclear if the input correlated to the top toggle or the bottom one. That concern could possibly be assuaged by reducing the vertical margin between the two controls, but I'm not sure, as it's already so small between the toggles.

On that note, you'll also need an aria-labelledby (example) on the base input pointing to the toggle's title to ensure that this is accessible for users with screen readers.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[absidue]

Suggested change

	:id="'onlyShowLatestFromChannel'"
	id="onlyShowLatestFromChannel"

[absidue]

Suggested change

	:placeholder="'1'"
	placeholder="1"

[absidue]

Suggested change

	:aria-labelledby="'onlyShowLatestFromChannel'"
	aria-labelledby="onlyShowLatestFromChannel"

[absidue]

Please don't use nested CSS unless there is absolutely no other way, as it breaks Vue's scoped CSS functionality, in this case a class would probably be a lot more suitable than doing some nth-child stuff. That would also allow you to use a plain CSS file.

[efb4f5ff-1298-471a-8973-3d47447115dc]

I didn't remove the old localisation string, is it removed automatically or do I need to do it.

Its not automatically, you need to remove it.

I imagine I have to remove it from all the files not just static/locales/en-US.yaml, right?

Thats correct

[efb4f5ff-1298-471a-8973-3d47447115dc]

• Lets only allow positive numbers >= 1

• Also we should set the limit to 30 as we dont display more than that
• I dont like how all the settings move when you enable this

VirtualBoxVM_08l4jeu4gq.mp4

[c-ciobanu]

• Lets only allow positive numbers >= 1

• Also we should set the limit to 30 as we dont display more than that
• I dont like how all the settings move when you enable this

VirtualBoxVM_08l4jeu4gq.mp4

Seeing how the input and the settings work right now I don't think it's possible to have a limit enforced nicely right now since there is no validation at all.

For the alignment something like this would be better:

simplescreenrecorder-2024-10-23_16.23.50.mp4

Layout not moving and it looks the same on lower resolutions.

Maybe instead of having an input a slider would be better?

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[c-ciobanu]

Hey, what's the status on this, what's blocking it from being merged?

[efb4f5ff-1298-471a-8973-3d47447115dc]

There shouldnt be any blockers now that conflicts are resolved

[kommunarr]

Looks great! Apologies for the delay; it can be tough for us to keep track of things as more tasks flow in.

[absidue]

I hope this doesn't come off as rude, but I generally skip past pull requests that have conflicts, as they can't be merged anyway, so there is no point reviewing it as I'll have to do it again anyway when the code conflicts have been resolved. It has also happened a few times that non-maintainers have abandoned their pull requests when they get code conflicts, so now I wait for signs of life from the developer before looking at such pull requests.

[c-ciobanu]

Sounds good, there are no conflicts any more.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.