Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from hashicorp:master #116

Open
wants to merge 1,590 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1590 commits
Select commit Hold shift + click to select a range
1e10051
Merge pull request #27501 from hashicorp/pselle/taint-err
Jan 14, 2021
63efb12
Update CHANGELOG.md
Jan 14, 2021
4ffacc8
Merge pull request #27502 from hashicorp/pselle/untaint-missing
Jan 14, 2021
3a50831
Update CHANGELOG.md
Jan 14, 2021
191124e
detect new outputs and plans as Create actions
jbardin Jan 14, 2021
a15c5c8
Merge pull request #27498 from hashicorp/alisdair/fix-remote-terrafor…
alisdair Jan 14, 2021
68b65cc
Merge pull request #27512 from hashicorp/jbardin/output-plans
jbardin Jan 14, 2021
ef7607d
update CHANGELOG.md
jbardin Jan 14, 2021
e865faf
command: Better visual hierarchy for diagnostics
apparentlymart Dec 19, 2020
54ebe6a
Update CHANGELOG.md
apparentlymart Jan 14, 2021
1c7c53a
Merge pull request #27404 from hashicorp/jan21_broken_link_check
nfagerlund Jan 14, 2021
e62979a
fix slash issue on windows
njuCZ Jan 15, 2021
7b3b401
Update index.html.md
fredtrimble Jan 16, 2021
212a97c
cli: Fix state migration remote version check
alisdair Jan 19, 2021
44daf76
remove InitProvisioner and close all at once
jbardin Jan 19, 2021
a6db207
remove provisioner graph nodes
jbardin Jan 15, 2021
fe7635f
always close all provisioners after each walk
jbardin Jan 19, 2021
63a9ab4
ensure that provisioners are not used after Close
jbardin Jan 19, 2021
ff30030
builtin provisioners are re-used and not Closed
jbardin Jan 19, 2021
21896f7
builtin provisioner e2e test
jbardin Jan 19, 2021
439d06b
comment updates
jbardin Jan 20, 2021
0403d89
Merge pull request #27549 from hashicorp/jbardin/provisioner-lifecycle
jbardin Jan 20, 2021
a7d50d3
Merge pull request #27545 from hashicorp/alisdair/remote-backend-vers…
alisdair Jan 20, 2021
9f2a6d3
move remaining helper packages to internal
jbardin Jan 20, 2021
08560ee
Merge pull request #27557 from hashicorp/jbardin/helper-packages
jbardin Jan 20, 2021
e4e5061
add failing test, and start new test files
jbardin Jan 21, 2021
cb7a08c
fix null check and shadowed state variable
jbardin Jan 21, 2021
543706c
Merge pull request #27563 from hashicorp/jbardin/refresh-tainted
jbardin Jan 21, 2021
4fe76d3
core: Fix crash for marked data source prior value
alisdair Jan 21, 2021
b33e107
Merge pull request #27567 from hashicorp/alisdair/planned-data-source…
alisdair Jan 22, 2021
084cec6
Merge pull request #27447 from Filirom1/fix-27445
Jan 22, 2021
81f9561
Merge pull request #27526 from fredtrimble/patch-1
Jan 22, 2021
22d7c11
website: Language: Remove the "this is 0.12+" message from language docs
nfagerlund Jan 15, 2021
b71786d
website: Language: Update sidebar nav with new URLs
nfagerlund Jan 15, 2021
78dcc8d
website: Language: Move files to match new URL structure
nfagerlund Jan 15, 2021
7a8dd32
website: Language: Update links to moved pages
nfagerlund Jan 15, 2021
8cfcd82
website: Language: Remove several ghost pages, update links
nfagerlund Jan 15, 2021
b909a4a
website: Move hidden attr-as-blocks page into new URL structure
nfagerlund Jan 16, 2021
ed7f97c
Update language docs URLs in code and tests
nfagerlund Jan 16, 2021
01a449e
website: CLI: Update sidebar nav with new URLs
nfagerlund Jan 15, 2021
a833270
website: CLI: Move docs files to match new URLs
nfagerlund Jan 19, 2021
d1e8537
website: CLI: Update links to moved docs pages
nfagerlund Jan 19, 2021
a601204
Update links to CLI docs in code comments, messages, and readme
nfagerlund Jan 19, 2021
33d2d9a
website: CLI: Remove several ghost pages, update old links
nfagerlund Jan 19, 2021
4e4f6b3
website: Restore note about standard vs. enhanced backends
nfagerlund Jan 22, 2021
4d65cbd
Merge pull request #27560 from hashicorp/jan21_language_and_cli_urls
nfagerlund Jan 22, 2021
6d016af
website: Remove links to legacy provider docs for GitHub, ksyun
nfagerlund Jan 22, 2021
bd6b973
Merge pull request #27575 from hashicorp/jan21_github_ksyun_removal
nfagerlund Jan 22, 2021
75d38b5
docs: Note: state pull upgrades to current version
alisdair Jan 22, 2021
f6951a5
Merge pull request #27572 from hashicorp/alisdair/document-state-pull…
alisdair Jan 25, 2021
aedca59
Reuse installed target dir providers in init
pselle Jan 23, 2021
e1b0e3c
Remove -module option for taint and untaint
pselle Jan 25, 2021
dd7b412
Merge pull request #27582 from hashicorp/pselle/reuse_targetdir_provi…
Jan 25, 2021
c066127
Merge pull request #27591 from hashicorp/pselle/taint-untaint-module
Jan 26, 2021
35d5ea5
Update state mv help docs to use spaces instead of tabs
pselle Jan 26, 2021
f658531
Updating terraform workspace website list.html.md new.html.md select.…
andormarkus Nov 11, 2020
6da55c0
Update grammar for flags
pselle Jan 26, 2021
5524515
Merge pull request #26891 from andormarkus/Update_workspace_docs
Jan 26, 2021
5682f55
Merge pull request #27597 from hashicorp/pselle/state-cli-docs
Jan 26, 2021
fda0f04
Update CHANGELOG.md
apparentlymart Jan 26, 2021
49ee3d3
Grammar nit: "setup" as a verb should be spelled "set up"
flimzy Jan 26, 2021
1a16ce8
Merge pull request #25687 from flimzy/setup
Jan 26, 2021
bc51932
refactor: extract appendSourceSnippets
kmoe Jan 18, 2021
51c687c
command: no visual warning hierarchy in -no-color
kmoe Jan 26, 2021
de31787
add missing import
kmoe Jan 27, 2021
657ae46
Release v0.15.0-alpha20210127
hashicorp-ci Jan 27, 2021
2e62e03
cli: Remove dead code for output -module flag
alisdair Jan 27, 2021
dc757c4
Cleanup after v0.15.0-alpha20210127 release
hashicorp-ci Jan 27, 2021
c1ede28
Update docstring for ignore-remote-version
pselle Jan 27, 2021
7cb5685
Merge pull request #27609 from hashicorp/alisdair/remove-output-modul…
alisdair Jan 27, 2021
29dd334
Merge pull request #27611 from hashicorp/pselle/ignore-remote-version…
Jan 27, 2021
ad8a2e8
deps: Bump github.com/aws/[email protected]
bflad Jan 28, 2021
2df2d21
removed orphaned data sources from the state
jbardin Jan 28, 2021
bd70df8
Merge pull request #27621 from hashicorp/jbardin/plan-orphan-data-ins…
jbardin Jan 29, 2021
5ca118b
cli: Move resource count code to command package
alisdair Jan 29, 2021
5df11f2
Merge pull request #27633 from hashicorp/alisdair/count-hook-refactor
alisdair Jan 29, 2021
e6daf3d
Unmark before ElementIterator in couldHaveUnknownBlockPlaceholder
pselle Jan 29, 2021
cf09435
update CHANGELOG.md
jbardin Feb 1, 2021
70aac9c
command: Use different warning messaging in init command and move abo…
bflad Feb 1, 2021
9c16e57
Merge pull request #27620 from hashicorp/v-aws-sdk-go-v1.37.0
jbardin Feb 2, 2021
ca23a09
cli: Remove legacy positional path arguments
alisdair Feb 2, 2021
888f36a
cli: Remove positional plan argument from graph
alisdair Feb 2, 2021
84f5b86
Merge pull request #27635 from hashicorp/pselle/obj-compatible-set
Feb 2, 2021
a51803a
Merge pull request #27664 from hashicorp/alisdair/remove-positional-p…
alisdair Feb 2, 2021
c8f83e1
Update CHANGELOG.md
alisdair Feb 2, 2021
1e5a8e4
fix concurrent test relying on sleep
jbardin Feb 2, 2021
030632e
Merge pull request #27668 from hashicorp/jbardin/parallelism-test
jbardin Feb 3, 2021
d4db1d1
fix possible nil pointer dereference in azure sdk
GreenHedgehog Feb 3, 2021
b2ba650
cli: Remove deprecated destroy -force flag
alisdair Feb 3, 2021
294bbd8
Merge pull request #27681 from hashicorp/alisdair/remove-deprecated-d…
alisdair Feb 4, 2021
8057f19
Update CHANGELOG.md
alisdair Feb 4, 2021
d7613a0
cli: Better diagnostics for apply positional args
alisdair Feb 3, 2021
181048b
Add crosslink to new Learn tutorial
robin-norwood Feb 4, 2021
4ec80fa
Correct the spelling of heirarchy/hierarchy throughout
alexwlchan Feb 5, 2021
f279bf5
Merge pull request #27689 from hashicorp/rln-data-sources-tutorial
robin-norwood Feb 5, 2021
32d2084
Merge pull request #27679 from hashicorp/alisdair/apply-destroy-test-…
alisdair Feb 5, 2021
f3a057e
plugin-protocol v6
mildwonkey Feb 5, 2021
3ad720e
configs/configschema: add new NestedType to attribute
mildwonkey Feb 5, 2021
da6ac9d
plans/objchange: add handling of NestedTypes inside attributes
mildwonkey Feb 5, 2021
7cae763
cli: Fix for provider requirements in JSON plan
alisdair Feb 5, 2021
1a8d873
plugin6: new plugin package to support plugin protocol v6
mildwonkey Feb 5, 2021
d7cbf8f
Fix typo
philipsahli Feb 8, 2021
e39abbf
fix regex logical or documentation (#27637)
stephengroat Feb 8, 2021
c840e9c
Fix empty diags not getting associated with source.
paddycarver Feb 8, 2021
4991cc4
cli: Improve error for invalid -target flags
alisdair Feb 8, 2021
a033598
update hcl and terraform-config-inspect
jbardin Feb 9, 2021
ac585be
initial support for parsing configuration_aliases
jbardin Feb 9, 2021
96be094
Merge pull request #27711 from hashicorp/alisdair/fix-target-flag-par…
alisdair Feb 9, 2021
aa24bfe
Emit ProviderAlreadyInstalled when provider installed
pselle Feb 9, 2021
f97f8c2
Merge pull request #27708 from philipsahli/patch-1
Feb 9, 2021
77af601
plans/objchange: extended ProposedNewObject to descend into attributes
mildwonkey Feb 10, 2021
0a99757
Merge pull request #27722 from hashicorp/pselle/init-installed
Feb 10, 2021
7aaffac
configload should not be doing validation
jbardin Feb 10, 2021
d96c90b
Cost Estimation CLI output unnecessary
omarismail Feb 10, 2021
d631eca
Release v0.15.0-alpha20210210
hashicorp-ci Feb 10, 2021
7720d4a
Cleanup after v0.15.0-alpha20210210 release
hashicorp-ci Feb 10, 2021
ffba806
terminal: StreamsForTesting helper
apparentlymart Feb 10, 2021
4ac095b
only print horizontal rule at first attempt
omarismail Feb 11, 2021
14936e6
Merge pull request #27735 from omarismail/cost-estimation-output
omarismail Feb 11, 2021
da252de
add provider validation
jbardin Feb 10, 2021
9b11ff0
remove outdated tests
jbardin Feb 10, 2021
00730ae
basic configuration_aliases support in core
jbardin Feb 10, 2021
6aa90a5
ContainsSensitive must descend into nested objects
mildwonkey Feb 11, 2021
943df48
cli: Optimize for large multi-line string outputs
alisdair Feb 11, 2021
04e512d
Merge pull request #27746 from hashicorp/alisdair/optimize-large-mult…
alisdair Feb 11, 2021
c5a6aa3
cli: Add initial command views abstraction
alisdair Jan 27, 2021
4195531
old comment
jbardin Feb 11, 2021
4e12ba3
Merge pull request #27739 from hashicorp/jbardin/provider-aliases
jbardin Feb 11, 2021
57879bf
cli: Add global view arguments parser
alisdair Feb 10, 2021
6f58037
Merge pull request #27738 from hashicorp/alisdair/command-views
alisdair Feb 12, 2021
1bb6028
update docs for configuration_aliases
jbardin Feb 12, 2021
6f26203
update CHANGELOG.md
jbardin Feb 12, 2021
1cf4909
configschema: fix various issues with NestedTypes
mildwonkey Feb 12, 2021
8c2abbc
return the properly-typed nulls, instead of empty containers, in prop…
mildwonkey Feb 12, 2021
f91a3b8
terminal: Helpers for doing fmt-ish operations on the streams
apparentlymart Feb 12, 2021
536c80d
backend: Add per-operation diagnostic rendering
alisdair Feb 12, 2021
dfd8424
link configuration aliases between pages
jbardin Feb 12, 2021
9859d4e
Update website/docs/language/modules/develop/providers.html.md
jbardin Feb 12, 2021
e407270
Update website/docs/language/modules/develop/providers.html.md
jbardin Feb 12, 2021
d54a9b1
Update website/docs/language/providers/configuration.html.md
jbardin Feb 12, 2021
3cd086f
views: Use new streams helper functions
alisdair Feb 12, 2021
6e72b04
Merge pull request #27710 from hashicorp/paddy_empty_diags
jbardin Feb 12, 2021
a351053
Merge pull request #27762 from hashicorp/alisdair/command-views-helpers
alisdair Feb 12, 2021
f52a18b
Update backend/remote-state/azure/client.go
mbfrahry Feb 15, 2021
2b42445
Update client.go
mbfrahry Feb 15, 2021
cb04105
Merge with master
mbfrahry Feb 15, 2021
fa774da
Merge pull request #27761 from hashicorp/alisdair/command-views-opera…
alisdair Feb 16, 2021
a7b7cd2
cli: Migrate Terraform UI hook to command views
alisdair Feb 12, 2021
2d1976b
clistate: Update clistate.Locker for command views
alisdair Feb 16, 2021
3257f31
backend/local: Return diag for refresh empty state
alisdair Feb 16, 2021
96cf291
views: Expand test coverage for views.Output
alisdair Feb 16, 2021
bb3f59b
Merge pull request #27697 from hashicorp/alisdair/json-plan-provider-…
alisdair Feb 16, 2021
1301e38
Merge pull request #27786 from hashicorp/alisdair/refresh-empty-diag
alisdair Feb 16, 2021
20cb28b
Merge pull request #27788 from hashicorp/alisdair/command-views-outpu…
alisdair Feb 16, 2021
1ae3d30
Merge pull request #27760 from hashicorp/alisdair/command-views-ui-hook
alisdair Feb 16, 2021
22f21db
reverse call to TestConformance in objchange
jbardin Feb 16, 2021
1bda146
Remove changelog entry for backported PR
alisdair Feb 16, 2021
7943312
Merge pull request #27699 from hashicorp/mildwonkey/protocolv6
mildwonkey Feb 16, 2021
0aa227e
cli: Fix misapplied terminal colors on run logs
alisdair Feb 16, 2021
0d63b3e
Merge pull request #27791 from hashicorp/jbardin/test-conformance-dyn…
jbardin Feb 16, 2021
f1a2926
terraform: Fix missing deposed key for PreApply
alisdair Feb 16, 2021
8fb319b
Merge pull request #27790 from hashicorp/alisdair/ui-hook-miscolored
alisdair Feb 16, 2021
f7dbb1a
Merge pull request #27796 from hashicorp/alisdair/fix-missing-deposed…
alisdair Feb 16, 2021
bfe791d
Update CHANGELOG.md
alisdair Feb 16, 2021
5b36b37
Merge pull request #27758 from hashicorp/jbardin/configuration_aliase…
jbardin Feb 16, 2021
6375c6c
Merge pull request #27787 from hashicorp/alisdair/command-views-state…
alisdair Feb 16, 2021
b582b19
Remove duplicate declaration
pselle Feb 16, 2021
d390fad
Merge pull request #27799 from hashicorp/pselle/fix_test
Feb 16, 2021
0639054
sentence refactor - consistently -> consistency
amslezak Feb 16, 2021
81dc028
backend/azurerm: updating the dependencies for the Azure Backend #26721
mbfrahry Feb 17, 2021
d89c8f5
Update changelog for #26721
mbfrahry Feb 17, 2021
b0094db
Merge pull request #27678 from GreenHedgehog/master
jbardin Feb 17, 2021
2b1dc1e
Merge pull request #27517 from njuCZ/fix_functions_tc
jbardin Feb 17, 2021
04b5c7d
Merge pull request #27800 from amslezak/patch-1
jbardin Feb 17, 2021
08b649b
Remove removed upgrade commands
pselle Feb 16, 2021
48bfde2
Merge pull request #27798 from hashicorp/pselle/upgrade_command_removal
Feb 17, 2021
85b9bde
backend/azure: azure state refreshes outside of grabbing the lock #26561
mbfrahry Feb 17, 2021
31387d2
Update changelog for #26561
mbfrahry Feb 17, 2021
6c57395
Test empty diagnostics.
paddycarver Feb 18, 2021
1d0414a
Merge pull request #27813 from hashicorp/paddy_empty_diags
alisdair Feb 18, 2021
2b4e389
Mildwonkey/nested type format (#27793)
mildwonkey Feb 18, 2021
24e7a55
Fix sentence in v0.14 upgrade guide
jessicastenning Feb 18, 2021
f650587
Mildwonkey/providers interface renaming (#27805)
mildwonkey Feb 18, 2021
e417d79
don't add duplicate proxy provider nodes
jbardin Feb 18, 2021
3f017b4
core: Unmark provisioner config before validation
alisdair Feb 18, 2021
8d2fbd4
Remove deprecation on undeclared variable, docs, and summary adjustme…
Feb 18, 2021
1b534ee
Update CHANGELOG.md
Feb 18, 2021
9de4f47
Update CHANGELOG.md
Feb 18, 2021
c0b2200
Merge pull request #27818 from hashicorp/alisdair/unmark-provisioner-…
alisdair Feb 18, 2021
0da0b24
provider transformer test mixing legacy stuff
jbardin Feb 18, 2021
68558cc
backend/local: Replace CLI with view instance
alisdair Feb 17, 2021
7f8b8a9
Merge pull request #27808 from hashicorp/alisdair/command-views-opera…
alisdair Feb 18, 2021
e1c2533
Delete readme, add doc.go to helper/schema
pselle Feb 18, 2021
84696ea
Merge pull request #27816 from jessicastenning/fix-docs-grammatical-m…
Feb 18, 2021
156b161
Remove 0.13upgrade test fixtures
pselle Feb 18, 2021
b3c2f71
Merge pull request #27821 from hashicorp/pselle/internal-helper-schema
Feb 18, 2021
28d3505
Merge pull request #27823 from hashicorp/pselle/upgrade-tool-testfixt…
Feb 18, 2021
3da5d2b
Merge pull request #27692 from alexwlchan/abolish-the-heirarchy
jbardin Feb 18, 2021
230658f
Upgrade ignore_changes wildcard from warning to error
pselle Feb 19, 2021
b1d8d85
remove ParentProviderTransformer
jbardin Feb 18, 2021
8c1703d
simplify the use of configuration_aliases
jbardin Feb 18, 2021
dd5227a
provider transformer tests
jbardin Feb 18, 2021
fa7c3d7
Remove interpolation-only warning
pselle Feb 19, 2021
6871d0c
update CHANGELOG.md
jbardin Feb 19, 2021
2f7c368
Document `inline` & `on_failure` behaviour
OJFord Feb 19, 2021
02eb283
backend/remote: Fix broken state lock retry
alisdair Feb 19, 2021
e5274f9
Merge pull request #27835 from hashicorp/pselle/warn-interpolation
Feb 19, 2021
cbacc53
Update CHANGELOG.md
Feb 19, 2021
61bee3c
Merge pull request #27834 from hashicorp/pselle/ignore-changes-wildcard
Feb 19, 2021
4e345b6
Update CHANGELOG.md
Feb 19, 2021
8f78076
Upgrade to quoted keywords to error
pselle Feb 19, 2021
b976178
cli: Remove no-op plan backend setup
alisdair Feb 22, 2021
3bd35b2
Merge pull request #27852 from hashicorp/pselle/quoted-keywords
Feb 22, 2021
1de8216
Update CHANGELOG.md
Feb 22, 2021
94340b5
cli: Add reference to global options to help text
alisdair Feb 22, 2021
7b7273e
Add support for plugin protocol v6 (#27826)
mildwonkey Feb 22, 2021
2f287b4
Add State Learn tutorial to State docs
Feb 22, 2021
43028c4
cli: Migrate apply to command views
alisdair Feb 18, 2021
4ccd818
Merge pull request #27845 from hashicorp/alisdair/fix-remote-backend-…
alisdair Feb 22, 2021
6bef157
Merge pull request #27860 from hashicorp/alisdair/remove-noop-plan-ba…
alisdair Feb 22, 2021
56b756c
Merge pull request #27841 from hashicorp/alisdair/command-views-apply
alisdair Feb 22, 2021
50d58b5
cli: Migrate refresh to command views
alisdair Feb 22, 2021
8330f8e
internal/moduletest: Experimental module testing helpers
apparentlymart Feb 5, 2021
7f78342
command: Experimental "terraform test" command
apparentlymart Feb 9, 2021
8d37a70
website: Initial docs for the module integration testing experiment
apparentlymart Feb 18, 2021
62b4d7b
Update CHANGELOG.md
apparentlymart Feb 22, 2021
eeb5dfb
Merge pull request #27865 from hashicorp/alisdair/command-views-refresh
alisdair Feb 23, 2021
8d9a08e
cli: Migrate plan to command views
alisdair Feb 22, 2021
b7f54b3
cli: Fix overly broad auto-approve argument
alisdair Feb 23, 2021
bf712e5
Merge pull request #27864 from hashicorp/alisdair/command-views-plan
alisdair Feb 23, 2021
3449a8a
don't marshal state with the wrong schema
jbardin Feb 23, 2021
160020a
Merge pull request #27824 from hashicorp/jbardin/proxy-providers
jbardin Feb 23, 2021
c7995b7
update show -json docs
jbardin Feb 23, 2021
e3abe90
build: Terraform is now built with Go 1.16
apparentlymart Feb 22, 2021
5f3fb00
config: Use Unicode 13 rules for string manipulation
apparentlymart Feb 23, 2021
c103242
Merge pull request #27885 from hashicorp/jbardin/show-json
jbardin Feb 23, 2021
7597f47
Update CHANGELOG.md
apparentlymart Feb 23, 2021
3cb4918
Merge pull request #27862 from hashicorp/add-state-learn-tutorial
Feb 23, 2021
79f855b
Merge pull request #27840 from OJFord/docs-27554
alisdair Feb 23, 2021
7a03c31
Merge pull request #27861 from hashicorp/alisdair/help-global-options
alisdair Feb 23, 2021
21d881d
Update "Terraform Core Architecture Summary" doc (#27897)
antoineco Feb 24, 2021
ff05362
providers.Interface: rename ValidateDataSourceConfig to ValidateDataR…
mildwonkey Feb 24, 2021
cd7fb9b
catch invalidly planned attributes earlier
jbardin Feb 24, 2021
e5a7586
moduletest: update provider to match recent provider interface change…
mildwonkey Feb 24, 2021
4271b0e
cli: Remove -var/-var-file flags from validate
alisdair Feb 24, 2021
9508ff2
website: Terraform v0.15 upgrade guide first draft
apparentlymart Feb 23, 2021
b735d80
website: Provider configuration notes for the v0.15 upgrade guide
jbardin Feb 24, 2021
326583b
Merge pull request #27906 from hashicorp/alisdair/remove-var-args-fro…
alisdair Feb 24, 2021
8c9083d
Merge pull request #27903 from hashicorp/jbardin/plan-valid-computed
jbardin Feb 24, 2021
6697245
Update CHANGELOG.md
alisdair Feb 24, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
104 changes: 102 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@ version: 2.1
orbs:
slack: circleci/[email protected]

references:
images:
middleman: &MIDDLEMAN_IMAGE docker.mirror.hashicorp.services/hashicorp/middleman-hashicorp:0.3.44

executors:
go:
docker:
- image: circleci/golang:1.14
- image: docker.mirror.hashicorp.services/circleci/golang:1.16
environment:
CONSUL_VERSION: 1.7.2
GOMAXPROCS: 4
GO111MODULE: "on"
GOPROXY: https://proxy.golang.org/
TEST_RESULTS_DIR: &TEST_RESULTS_DIR /tmp/test-results
ARTIFACTS_DIR: &ARTIFACTS_DIR /tmp/artifacts
GOFLAGS: "-mod=vendor"

jobs:
go-checks:
Expand All @@ -38,6 +41,8 @@ jobs:
go-test:
executor:
name: go
environment:
TF_CONSUL_TEST: 1
parallelism: 4
steps:
- checkout
Expand Down Expand Up @@ -175,6 +180,97 @@ jobs:
name: test docker build for 'full' image
command: docker build -t test-docker-full .

# Based on a similar job in terraform-website repo.
website-link-check:
docker:
- image: *MIDDLEMAN_IMAGE
steps:
- checkout:
path: terraform

- run:
name: Determine changed website files, if any
working_directory: terraform
command: |
# Figure out what the current branch forked from. Compare against
# master and the set of "vX.Y" branches, and choose whichever branch
# we're the *fewest* commits ahead of.
# The point here isn't to perfectly predict where this will be
# merged; all we really care about is determining which commits are
# *unique to this PR,* so we don't accidentally complain about
# problems you had nothing to do with.
PARENT_BRANCH=$(
for br in $(git branch -rl --format='%(refname:short)' | grep -E '^origin/(master|v\d+\.\d+)$'); do
new_commits=$(git rev-list --first-parent ^${br} HEAD | wc -l);
echo "${br} ${new_commits}";
done \
| sort -n -k2 \
| head -n1 \
| awk '{print $1}';
)
echo "Checking current branch against: ${PARENT_BRANCH}"
MERGE_BASE=$(git merge-base HEAD ${PARENT_BRANCH})
git diff --name-only -z --diff-filter=AMRCT ${MERGE_BASE}..HEAD -- ./website/ > /tmp/changed-website-files.txt
# --name-only: Return a list of affected files but don't show the changes.
# -z: Make that a null-separated list (instead of newline-separated), and
# DON'T mangle non-ASCII characters.
# --diff-filter=AMRCT: Only list files that were added, modified, renamed,
# copied, or had their type changed (file, symlink, etc.). In
# particular, we don't want to check deleted files.
# ${MERGE_BASE}..HEAD: Only consider files that have
# changed since this branch diverged from its parent branch.
# -- ./website/: Only consider files in the website directory.
echo "Changed website files:"
cat /tmp/changed-website-files.txt | tr '\0' '\n'
# Need to use "tr" for display because it's a null-separated list.

- run:
name: Exit early if there's nothing to check
command: |
if [ ! -s /tmp/changed-website-files.txt ]; then
circleci-agent step halt
fi

- run:
name: Check out terraform-website repo
command: git clone [email protected]:hashicorp/terraform-website.git

- run:
name: Use local checkout for terraform submodule, instead of cloning again
working_directory: terraform-website
command: |
# Set submodule's URL to our existing checkout.
# (Using `pwd` because git's behavior with strictly relative paths is unreliable.)
git config --file=.gitmodules submodule.ext/terraform.url $(pwd)/../terraform/.git
# Make it so `make sync` will grab our current branch instead of stable-website.
git config --file=.gitmodules submodule.ext/terraform.branch HEAD

- run:
name: Init/update terraform-website submodules
working_directory: terraform-website
command: make sync

- run:
name: Set up terraform-website dependencies
working_directory: terraform-website/content
# If this does anything interesting, then the container needs an update.
command: bundle check || bundle install --path vendor/bundle --retry=3

- run:
name: Run middleman in background
working_directory: terraform-website/content
background: true
command: bundle exec middleman server

- run:
name: Wait for server to start
command: until curl -sS http://localhost:4567/ > /dev/null; do sleep 1; done

- run:
name: Check links in changed pages
working_directory: terraform-website/content
command: cat /tmp/changed-website-files.txt | bundle exec ./scripts/check-pr-links.rb

workflows:
version: 2
test:
Expand Down Expand Up @@ -202,3 +298,7 @@ workflows:
- build-386
- build-amd64
- build-arm

website-test:
jobs:
- website-link-check
21 changes: 11 additions & 10 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ The Terraform team is not merging PRs for new state storage backends at the curr

Please see the [CODEOWNERS](https://github.com/hashicorp/terraform/blob/master/CODEOWNERS) file for the status of a given backend. Community members with an interest in a particular standard backend are welcome to help maintain it.

Currently, merging state storage backends places a significant burden on the Terraform team. The team must setup an environment and cloud service provider account, or a new database/storage/key-value service, in order to build and test remote state storage backends. The time and complexity of doing so prevents us from moving Terraform forward in other ways.
Currently, merging state storage backends places a significant burden on the Terraform team. The team must set up an environment and cloud service provider account, or a new database/storage/key-value service, in order to build and test remote state storage backends. The time and complexity of doing so prevents us from moving Terraform forward in other ways.

We are working to remove ourselves from the critical path of state storage backends by moving them towards a plugin model. In the meantime, we won't be accepting new remote state backends into Terraform.

#### Provisioners

Provisioners are an area of concern in Terraform for a number of reasons. Chiefly, they are often used in the place of configuration management tools or custom providers.
Provisioners are an area of concern in Terraform for a number of reasons. Chiefly, they are often used in the place of configuration management tools or custom providers.

There are two main types of provisioners in Terraform, the generic provisioners (`file`,`local-exec`, and `remote-exec`) and the tool-specific provisioners (`chef`, `habbitat`, `puppet` & `salt-masterless`). **The tool-specific provisioners [are deprecated](https://discuss.hashicorp.com/t/notice-terraform-to-begin-deprecation-of-vendor-tool-specific-provisioners-starting-in-terraform-0-13-4/13997).** In practice this means we will not be accepting PRs for these areas of the codebase.

From our [documentation](https://www.terraform.io/docs/provisioners/index.html):

Expand Down Expand Up @@ -137,7 +139,7 @@ If you wish to work on the Terraform CLI source code, you'll first need to insta

At this time the Terraform development environment is targeting only Linux and Mac OS X systems. While Terraform itself is compatible with Windows, unfortunately the unit test suite currently contains Unix-specific assumptions around maximum path lengths, path separators, etc.

Refer to the file [`.go-version`](https://github.com/hashicorp/terraform/blob/master/.github/.go-version) to see which version of Go Terraform is currently built with. Other versions will often work, but if you run into any build or testing problems please try with the specific Go version indicated. You can optionally simplify the installation of multiple specific versions of Go on your system by installing [`goenv`](https://github.com/syndbg/goenv), which reads `.go-version` and automatically selects the correct Go version.
Refer to the file [`.go-version`](https://github.com/hashicorp/terraform/blob/master/.go-version) to see which version of Go Terraform is currently built with. Other versions will often work, but if you run into any build or testing problems please try with the specific Go version indicated. You can optionally simplify the installation of multiple specific versions of Go on your system by installing [`goenv`](https://github.com/syndbg/goenv), which reads `.go-version` and automatically selects the correct Go version.

Use Git to clone this repository into a location of your choice. Terraform is using [Go Modules](https://blog.golang.org/using-go-modules), and so you should *not* clone it inside your `GOPATH`.

Expand Down Expand Up @@ -201,7 +203,7 @@ make protobuf

## External Dependencies

Terraform uses Go Modules for dependency management, but currently uses "vendoring" to include copies of all of the external library dependencies in the Terraform repository to allow builds to complete even if third-party dependency sources are unavailable.
Terraform uses Go Modules for dependency management.

Our dependency licensing policy for Terraform excludes proprietary licenses and "copyleft"-style licenses. We accept the common Mozilla Public License v2, MIT License, and BSD licenses. We will consider other open source licenses in similar spirit to those three, but if you plan to include such a dependency in a contribution we'd recommend opening a GitHub issue first to discuss what you intend to implement and what dependencies it will require so that the Terraform team can review the relevant licenses to for whether they meet our licensing needs.

Expand All @@ -213,24 +215,23 @@ go get github.com/hashicorp/hcl/[email protected]

This command will download the requested version (2.0.0 in the above example) and record that version selection in the `go.mod` file. It will also record checksums for the module in the `go.sum`.

To complete the dependency change, clean up any redundancy in the module metadata files and resynchronize the `vendor` directory with the new package selections by running the following commands:
To complete the dependency change, clean up any redundancy in the module metadata files by running:

```
go mod tidy
go mod vendor
```

To ensure that the vendoring has worked correctly, be sure to run the unit test suite at least once in *vendoring* mode, where Go will use the vendored dependencies to build the test programs:
To ensure that the upgrade has worked correctly, be sure to run the unit test suite at least once:

```
go test -mod=vendor ./...
go test ./...
```

Because dependency changes affect a shared, top-level file, they are more likely than some other change types to become conflicted with other proposed changes during the code review process. For that reason, and to make dependency changes more visible in the change history, we prefer to record dependency changes as separate commits that include only the results of the above commands and the minimal set of changes to Terraform's own code for compatibility with the new version:

```
git add go.mod go.sum vendor
git commit -m "vendor: go get github.com/hashicorp/hcl/[email protected]"
git add go.mod go.sum
git commit -m "go get github.com/hashicorp/hcl/[email protected]"
```

You can then make use of the new or updated dependency in new code added in subsequent commits.
15 changes: 13 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
name: Bug report
about: Let us know about an unexpected error, a crash, or an incorrect behavior.
labels: bug, new

---

Expand All @@ -9,7 +10,17 @@ Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue tracker reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

If your issue relates to a specific Terraform provider, please open it in the provider's own repository. The index of providers is at https://github.com/terraform-providers .
If your issue relates to a specific Terraform provider, please open it in the provider's own repository. The index of providers is at https://github.com/terraform-providers.

To fix problems, we need clear reproduction cases - we need to be able to see it happen locally. A reproduction case is ideally something a Terraform Core engineer can git-clone or copy-paste and run immediately, without inventing any details or context.

* A short example can be directly copy-pasteable; longer examples should be in separate git repositories, especially if multiple files are needed
* Please include all needed context. For example, if you figured out that an expression can cause a crash, put the expression in a variable definition or a resource
* Set defaults on (or omit) any variables. The person reproducing it should not need to invent variable settings
* If multiple steps are required, such as running terraform twice, consider scripting it in a simple shell script. For example, see [this case](https://github.com/danieldreier/terraform-issue-reproductions/tree/master/25719). Providing a script can be easier than explaining what changes to make to the config between runs.
* Omit any unneeded complexity: remove variables, conditional statements, functions, modules, providers, and resources that are not needed to trigger the bug
* When possible, use the [null resource](https://www.terraform.io/docs/providers/null/resource.html) provider rather than a real provider in order to minimize external dependencies. We know this isn't always feasible. The Terraform Core team doesn't have deep domain knowledge in every provider, or access to every cloud platform for reproduction cases.

-->

### Terraform Version
Expand All @@ -27,7 +38,7 @@ If you are not running the latest version of Terraform, please try upgrading bec
<!--
Paste the relevant parts of your Terraform configuration between the ``` marks below.

For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file. For security, you can also encrypt the files using our GPG public key.
For Terraform configs larger than a few resources, or that involve multiple files, please make a GitHub repository that we can clone, rather than copy-pasting multiple files in here. For security, you can also encrypt the files using our GPG public key at https://www.hashicorp.com/security.
-->

```terraform
Expand Down
3 changes: 2 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
name: Feature request
about: Suggest a new feature or other enhancement.
labels: enhancement
labels: enhancement, new

---

<!--
Expand Down
4 changes: 0 additions & 4 deletions .github/SECURITY.md

This file was deleted.

21 changes: 21 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
name: Backport Assistant Runner

on:
pull_request_target:
types:
- closed

jobs:
backport:
if: github.event.pull_request.merged
runs-on: ubuntu-latest
container: hashicorpdev/backport-assistant:0.2.1
steps:
- name: Run Backport Assistant
run: |
backport-assistant backport
env:
BACKPORT_LABEL_REGEXP: "(?P<target>\\d+\\.\\d+)-backport"
BACKPORT_TARGET_TEMPLATE: "v{{.target}}"
GITHUB_TOKEN: ${{ secrets.ELEVATED_GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ website/node_modules
*.iml

website/vendor
vendor/

# Test exclusions
!command/testdata/**/*.tfstate
Expand Down
2 changes: 1 addition & 1 deletion .go-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.14.2
1.16.0
1 change: 0 additions & 1 deletion .tfdev
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
version_info {
commit_var = "main.GitCommit"
version_var = "github.com/hashicorp/terraform/version.Version"
prerelease_var = "github.com/hashicorp/terraform/version.Prerelease"
}
Expand Down
Loading