Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support super long URLs by settings max height for URL #197

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

kgpax
Copy link
Member

@kgpax kgpax commented Jan 6, 2024

What does this PR do?

  • Sets a max height scrollable container for the trace URL
  • Ensures that really long URLs do not push the trace detail content down the page, potentially pushing it out of view altogether
  • Adds new mock trace demonstrating a super long URL

Screenshots

Before After
image image

Fixes #196

Copy link

changeset-bot bot commented Jan 6, 2024

🦋 Changeset detected

Latest commit: f3c60fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@envyjs/webui Patch
@envyjs/apollo Patch
@envyjs/core Patch
@envyjs/nextjs Patch
@envyjs/node Patch
@envyjs/web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kgpax kgpax merged commit a837b9a into main Jan 7, 2024
2 checks passed
@kgpax kgpax deleted the fix/super-long-urls branch January 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Super long URLs mean very small detail area
2 participants