Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace getData() to get_data() #41

Merged
merged 5 commits into from
Jul 14, 2024
Merged

chore: replace getData() to get_data() #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e387d45
replace getData() to get_data()
Autumn60 Jul 13, 2024
7d28e24
replace getData to get_data
Autumn60 Jul 13, 2024
570551a
Merge branch 'main' into chore/common/fix_naming_conv
Autumn60 Jul 13, 2024
e1432f6
Merge branch 'main' into chore/common/fix_naming_conv
Autumn60 Jul 14, 2024
b836bba
Merge branch 'main' into chore/common/fix_naming_conv
Autumn60 Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/wheel_stuck_utils/include/wheel_stuck_utils/ros/no_callback_subscription.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class NoCallbackSubscription
noexec_subscription_options);
}

typename TMessage::ConstSharedPtr getData()
typename TMessage::ConstSharedPtr get_data()
{
auto data = std::make_shared<TMessage>();
rclcpp::MessageInfo message_info;
Expand Down
6 changes: 3 additions & 3 deletions src/planning/dwa_planner/src/dwa_planner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,23 +151,23 @@ bool DWAPlanner::subscribe_and_validate()

bool DWAPlanner::try_subscribe_map()
{
auto map_msg = map_sub_->getData();
auto map_msg = map_sub_->get_data();
if (!map_msg) return false;
map_ = map_msg;
return true;
}

bool DWAPlanner::try_subscribe_odom()
{
auto odom_msg = odom_sub_->getData();
auto odom_msg = odom_sub_->get_data();
if (!odom_msg) return false;
odom_ = odom_msg;
return true;
}

bool DWAPlanner::try_subscribe_goal()
{
auto goal_msg = goal_sub_->getData();
auto goal_msg = goal_sub_->get_data();
if (!goal_msg) return false;
goal_ = goal_msg;
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/sample/simple_int_subscriber/src/polling_int_subscriber.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ PollingIntSubscriber::PollingIntSubscriber(const rclcpp::NodeOptions & options)

void PollingIntSubscriber::update()
{
const auto msg = sub_->getData();
const auto msg = sub_->get_data();
if (msg) {
std::cout << "Received: '" << msg->data << "'" << std::endl;
} else {
Expand Down
Loading