Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename point_types to point_xyzir #128

Merged
merged 3 commits into from
Aug 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef VELODYNE_CLOUD_SEPARATOR__POINT_TYPES_HPP_
#define VELODYNE_CLOUD_SEPARATOR__POINT_TYPES_HPP_
#ifndef VELODYNE_CLOUD_SEPARATOR__POINT_XYZIR_HPP_
#define VELODYNE_CLOUD_SEPARATOR__POINT_XYZIR_HPP_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

インクルードガード名をPOINT_XYZIR_HPP_に変えてほしいです。(ディレクトリ構造と一致させるため)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

現時点で、インクルードガード名とディレクトリ構造は一致していると思います。


#include <pcl/point_types.h>

Expand All @@ -32,4 +32,4 @@ POINT_CLOUD_REGISTER_POINT_STRUCT(
pcl::PointXYZIR,
(float, x, x)(float, y, y)(float, z, z)(float, intensity, intensity)(uint16_t, ring, ring))

#endif // VELODYNE_CLOUD_SEPARATOR__POINT_TYPES_HPP_
#endif // VELODYNE_CLOUD_SEPARATOR__POINT_XYZIR_HPP_
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#ifndef VELODYNE_CLOUD_SEPARATOR__VELODYNE_CLOUD_SEPARATOR_HPP_
#define VELODYNE_CLOUD_SEPARATOR__VELODYNE_CLOUD_SEPARATOR_HPP_

#include "velodyne_cloud_separator/point_types.hpp"
#include "velodyne_cloud_separator/point_xyzir.hpp"

#include <rclcpp/rclcpp.hpp>
#include <wheel_stuck_common_utils/ros/function_timer.hpp>
Expand Down
Loading