Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(description): create fourth_robot pkg #120

Merged
merged 13 commits into from
Oct 6, 2024

Conversation

Autumn60
Copy link
Collaborator

@Autumn60 Autumn60 commented Aug 6, 2024

description系パッケージのサンプルとして、https://github.com/CIR-KIT/fourth_robot_pkg より4th_robotを追加。

ros2 launch wheel_stuck_launcher wheel_stuck.launch.xml robot_model:=fourth_robot sensor_kit_model:=fourth_robot_sensor_kit 後、Rviz上でRobotDescriptionを表示することで確認が可能。

(面倒だったのでxacro::includeは使ってないです・・・きっと誰かが直してくれるはず)
-> 修正DONE

@Autumn60 Autumn60 requested a review from RyodoTanaka August 6, 2024 12:06
Copy link
Contributor

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xacro:include を使うように修正されたらマージで良いと思います!
4号機がまさかの蘇りでうれしい

@RyodoTanaka RyodoTanaka marked this pull request as draft August 13, 2024 12:44
@Autumn60 Autumn60 marked this pull request as ready for review August 30, 2024 17:30
@Autumn60 Autumn60 requested a review from RyodoTanaka August 30, 2024 17:30
Copy link
Contributor

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ヨシ!

@Autumn60 Autumn60 merged commit 159bea5 into main Oct 6, 2024
4 checks passed
@Autumn60 Autumn60 deleted the feat/description/create_sample_description_pkg branch October 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants