-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(description): create fourth_robot pkg #120
Merged
Autumn60
merged 13 commits into
main
from
feat/description/create_sample_description_pkg
Oct 6, 2024
Merged
feat(description): create fourth_robot pkg #120
Autumn60
merged 13 commits into
main
from
feat/description/create_sample_description_pkg
Oct 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
RyodoTanaka
reviewed
Aug 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xacro:include を使うように修正されたらマージで良いと思います!
4号機がまさかの蘇りでうれしい
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
Signed-off-by: Autumn60 <[email protected]>
RyodoTanaka
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ヨシ!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description系パッケージのサンプルとして、https://github.com/CIR-KIT/fourth_robot_pkg より4th_robotを追加。
ros2 launch wheel_stuck_launcher wheel_stuck.launch.xml robot_model:=fourth_robot sensor_kit_model:=fourth_robot_sensor_kit
後、Rviz上でRobotDescriptionを表示することで確認が可能。(面倒だったのでxacro::includeは使ってないです・・・きっと誰かが直してくれるはず)
-> 修正DONE