Allow specification of which interfaces to bind to #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the container has multiple interfaces/multiple IPs, it may be necessary to specify which interfaces Samba should use. In my case (microk8s+multus) it was listening additionally on a k8s-internal IP address and registering that IP address in DNS, which clients on the LAN would not be able to reach. This change allows specification of an environment variable
BINDINTERFACES
that becomes theinterfaces
value in smb.conf. The default is${HOSTIP} lo
which excluded any IPs other than the HOSTIP value.This is a change from previous behavior, where all interfaces would be used, but this new behavior is probably desirable. The old behavior can be preserved by providing
false
explicitly inBINDINTERFACES
.