-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FirebaseCloudMessaging.cpp #268
base: master
Are you sure you want to change the base?
Conversation
fix for https: instead of http:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
In addition, some code changes may need to be done in ESP8266 Arduino bsp side. File ESP8266HTTPClient.cpp
`
protected:
`
} |
CLAs look good, thanks! |
cc'ing @ed7coyne |
Also see #347 |
fix for https: instead of http: