Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large-scale refactoring #63

Merged
merged 13 commits into from
Jan 7, 2019
+861 −473
Merged

Large-scale refactoring #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
25512a1
:bug: Fixes #45.
Mar 23, 2018
0c2e1a4
Removes unnecessary transitions from chartframe.js
Dec 12, 2018
f2d9653
Removed half the stupid .data() calls
Dec 12, 2018
6283f37
All useless selections removed hurrah :tada:
Dec 12, 2018
e031c7f
Removes dependency on d3-transition
Dec 12, 2018
e5f77ad
Possibly breaking -- this should probably be sourceStyle, not subtitl…
Dec 13, 2018
475592d
Adding deprecation notice for .backgroundColour()
Dec 14, 2018
dadd728
Improving test coverage. Fixes #36.
Dec 14, 2018
cdfa143
Merge branch 'refactoring' into works-in-jsdom
Dec 14, 2018
076566a
Reinstating pure SVG context test.
Dec 14, 2018
caeaa22
:bug: Fixes #45. (#46)
Dec 14, 2018
4bd17c5
PR tweaks
Jan 7, 2019
539cb08
Merge branch 'refactoring' of github.com:Financial-Times/g-chartframe…
Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
469 changes: 213 additions & 256 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"minify": "uglifyjs --compress --minify -- build/g-chartframe.js > build/g-chartframe.min.js",
"test": "jest --coverage",
"prepare": "npm run build",
"report-coverage": "nyc report --reporter=lcov && codecov"
"report-coverage": "codecov"
},
"homepage": "https://github.com/Financial-Times/g-chartframe/",
"contributors": [
Expand All @@ -38,16 +38,15 @@
"babel-core": "^7.0.0-bridge.0",
"babel-jest": "^23.6.0",
"codecov": "^3.0.0",
"d3-transition": "^1.1.0",
"eslint": "^4.11.0",
"eslint-config-airbnb-base": "^12.1.0",
"eslint-plugin-import": "^2.8.0",
"jest": "^23.6.0",
"jsdom": "^11.4.0",
"jsdom": "^11.6.0",
"npm-prepublish": "^1.2.3",
"prettier-eslint": "^8.8.2",
"rollup": "0.25",
"rollup-plugin-babel": "^4.0.0-beta.0",
"rollup-plugin-babel": "^4.1.0",
"rollup-plugin-commonjs": "^8.2.6",
"rollup-plugin-node-resolve": "^3.0.0",
"uglify-es": "^3.1.10",
Expand Down
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,12 @@ A convenience setter: Set as many values as you choose by passing a big object t

This get the frame to try and automatically comput its top margin. _Not really reccomended though it it used by the pre-packaged webframes_.

<a id="frame-backgroundColour" href="#frame-backgroundColour">#</a>frame.**backgroundColour(_string_)**
<a id="frame-backgroundColor" href="#frame-backgroundColor">#</a>frame.**backgroundColor(_string_)**

Set the background colour of the frame. For the single argument you can use the same css color naming schemes that you use in HTML, whether that's color names (that is red), rgb values (that is rgb(255,0,0)), hex values, rgba values, etc. If no argument is specified returns the current value.
Set the background color of the frame. For the single argument you can use the same css color naming schemes that you use in HTML, whether that's color names (that is red), rgb values (that is rgb(255,0,0)), hex values, rgba values, etc. If no argument is specified returns the current value.

```js
myFrame.backgroundColour('#00FF00');
myFrame.backgroundColor('#00FF00');
```

<a id="frame-containerClass" href="#frame-containerClass">#</a>frame.**containerClass(_string_)**
Expand Down
Loading