Issue #71 fix

[nezda]

[#71] use configured TimeZone when deserializing instants (longs) into LocalDate/LocalDateTime

[cowtowncoder]

Quick question: do you think this is safe enough fix to include in 2.6.2 patch? Or should it go in master for 2.7?

[nezda]

I believe it is safe enough to include in a patch: copied structure from elsewhere to access ctxt.getTimeZone() and has tests.

[cowtowncoder]

I don't doubt the code works in that sense, but was more wondering whether users could face problems with it. LocalDate is supposed not to have specific time zone, so it may well not matter (that is, usage that assumes specific tz would seem suspect).

But assuming this is fine for either 2.6 or 2.7, one thing I need for merging is a CLA (apologies if I have received one earlier; I tried to find one). It's here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and what is usually done is that contributor prints, fills & signs it, scans and emails to info at fasterxml dot com. Once we receive it, I can merge the patch.
If you could do that, I'd be happy to merge the patch appropriately.

[nezda]

I see -- it is possible someone deserializing a LocalDate or LocalDateTime encoded as a long (rare?) might be surprised by this change but this change gives them the capability to work around it easily too by setting their context TimeZone to their local timezone, although they'd been depending on a bug. I'd love to see the change in 2.6.2.

Just sent signed CLA.

[cowtowncoder]

Thanks, CLA received and handled.

I sent a note on dev list, and would like to see if anyone else has opinion. I know there are couple of developers more knowledgeable wrt date/time, Joda, Java 8 date/time than I am, hoping they would chime in.

I agree in that combination of long value, local date, should mean this is reasonably safe change.
But at the same time use of Joda is so wide that even if only minority uses that combination it can affect many end users. So better safe than sorry.

[cowtowncoder]

Ok, I think this makes, and should go in 2.6[.2].

[cowtowncoder]

Merged; will see if I can do any cleanup (wrt access of tz), release 2.6.2.

[nezda]

Awesome!