[ JSTEP-10 ] Migrate smile module tests to JUnit 5
#553
Conversation
| import java.io.ByteArrayOutputStream; | ||
| import java.io.IOException; |
There was a problem hiding this comment.
@cowtowncoder One thing tho, IntelliJ doesn't provide per-package wildcard handling 🤔 minimum 3 required to use wildcard. But with that trade off, we get to order imports Jackson way that I configured like below (There are more above and below)
There was a problem hiding this comment.
I think that ideally we'd usually left imports as-is and avoid mechanical changes.
But FWTW, the usual cut-off is 5-or-more, I think. Then again for some packages (java.io, java.util) could use star-include for lower numbers.
I think that order of imports is more important than exact threshold for start includes, if that helps? (i.e. I'd rather have strict(er) ordering than worry about explicit vs star inclusion, if only one can be restricted).
There was a problem hiding this comment.
Good to hear that ordering comes first!
Though I hope merging into master doesn't complicate as much tho
related #547
Blocked by #548