Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): make rottentomatoes matching more robust #1265

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

benhaney
Copy link
Contributor

@benhaney benhaney commented Jan 15, 2025

Description

Replaces the RT search result matching logic with a ranking system that should be more robust. Also changes RT search queries to only search for the desired result type (movie or tv) and strips "The" from movie search queries.

From my testing so far, this fixes a handful of mismatched ratings, but there are some matches that this fails on in the same way as the old logic. Usually the examples that still fail are just absurd data, like results with release years that disagree by more than 1 year (eg, Terrifier which finished production in 2016 but wasn't widely released until 2018) or just have bad RT entries (eg, Nightmare Before Christmas which has two RT entries: one with all the ratings called Tim Burton's Nightmare Before Christmas, and another dummy entry with no ratings called just Nightmare Before Christmas which always matches better).

I want to make sure this doesn't make any matches worse, so I'm leaving it as a draft until I have time to do some more comprehensive testing. I've scraped the RT search results for the first ~1000 movies in Jellyseerr's Movies tab and fed them through the old and new logic, but I still need to test TV show matching and changes to the search query.

Gotta name all the magic numbers too.

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@Fallenbagel Fallenbagel changed the title fix(api): Make rottentomatoes matching more robust feat(api): make rottentomatoes matching more robust Jan 15, 2025
@Fallenbagel
Copy link
Owner

Fallenbagel commented Jan 15, 2025

Changed it to feat as I would classify this as an enhancement that makes an existing feature better and more robust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RottenTomatoes title match failure
2 participants