Convention Drink Tags

[TheDeathlyCow]

Original issue: #4378

Implements conventional drink tags and documents standards for mods to use when creating further tags, using the following definition of a 'drink' (which is included in the javadoc):

Drinks are defined as (1) consumable items that (2) use the drink use action, (3) can be consumed regardless of the player's current hunger, and (4, optional) do not (generally) have a food component.

Documents a standard that categories of drinks, such as Coffee, Tea, or Alcoholic drinks should be placed in a sub-tag, such as #c:drinks/coffee, #c:drinks/tea, and #c:drinks/alcohol.

Specific types of drinks, such as Lattes, Green Tea, and Beer should go in sub-sub-tags using their regular name, such as #c:drinks/coffee/latte, #c:drinks/tea/green_tea, and #c:drinks/alcohol/beer.

Sizes of drinks, such as buckets and bottles, can be distinguished using the #c:drink_containing/* tags. For example, drinkable honey buckets would be all items that belong to #c:drinks/honey AND #c:drinks/bucket.

Something that may be notable about this PR is that if merged, it would be the first use of sub-sub-tags in the convention tags API. Would this be wanted in the API, or would these tags be too granular?

Here is the full list of tags added:

• #c:drinks for all drinkable items (similar to #c:foods)
• #c:drinks/water for drinkable water items (potions)
• #c:drinks/milk for drinkable milk items (milk bucket)
• #c:drinks/honey for drinkable honey items (honey bottle) - this tag is an exception to the no food component rule (4). However, it is included based on the fact that the Minecraft Wiki categorizes Honey Bottles as both food and a drink: https://minecraft.wiki/w/Drinks. It otherwise meets both of the required rules 1-3 described above. Honey Bottles are also already included in the #c:foods tag, but otherwise have no tag of their own.
• #c:drinks/magic for drinks that are magical in nature and give status effects when consumed (potions and ominous bottles)
• #c:drinks/magic/ominous for drinks that grant Bad Omen (ominous bottle)
• #c:drinks/juice for all juices (empty)
• #c:drinks/juice/apple (empty)
• #c:drinks/juice/beetroot (empty)
• #c:drinks/juice/carrot (empty)
• #c:drinks/juice/watermelon (empty)
• #c:drink_containing/bucket for all non-empty drinkable buckets (milk bucket)
• #c:drink_containing/bottle for all non-empty drinkable bottles (potions, honey bottles, ominous bottles)

[TelepathicGrunt]

There is discussion on the neo issue report about the drinks tag

neoforged/NeoForge#1853

[Juuxel]

Looks generally great and it would be great to have standard IDs for these tags. For example, I've used similar names but under #c:foods/ instead (which is definitely worse).

I think the major weird thing here is c:drinks/water containing potions, but that might be inevitable since water bottles are minecraft:potions too.

[TheDeathlyCow]

Yeah it is unfortunately a bit weird quirk of how potions work. However, all potions that are brewable are brewed from water. So I think it's fair to at least say that all potions are water based and can be included in the water tag.