bgpd: last reset SNAFU #17881
Open
bgpd: last reset SNAFU #17881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/last_reset_reason
branch
from
6f742a0 to
0e961cc
Compare
ton31337
force-pushed
the
fix/last_reset_reason
branch
2 times, most recently
from
adca1c4 to
4381a7f
Compare
This is actually not reset, and should be ignored showing it as last reset under `show bgp neighbor`. Fixes: 1e91f1d ("bgpd: Update failed reason to distinguish some NHT scenario") Signed-off-by: Donatas Abraitis <[email protected]>
…aults Move checking if the peer is active only after we apply defaults for address families. If the family got activated after applying the defaults we should reset last_reset reason. Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/last_reset_reason
branch
from
4381a7f to
9a5be11
Compare
donaldsharp
reviewed
Jan 21, 2025
| @@ -2163,6 +2163,9 @@ bgp_establish(struct peer_connection *connection) | |||
| peer->established++; | |||
| bgp_fsm_change_status(connection, Established); | |||
|
|
|||
| if (peer->last_reset == PEER_DOWN_WAITING_OPEN) | |||
There was a problem hiding this comment.
I really don't get this change. Can you help me understand why displaying this is not good? And if we don't want to use PEER_DOWN_WAITING_OPEN why keep it?
There was a problem hiding this comment.
When the peer is created, "last reset" is displayed as "Waiting for OPEN" even when the connection is established which is something a "confusing part" (because it wasn't reset actually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17868