-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-emphasizing phones #294
base: main
Are you sure you want to change the base?
Conversation
This looks good to me. T |
@miriamsr will you be able to finish this by next week? |
@emcclurg Yes, I will get back to work on this, end of next week should be doable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily rn but we may want to call the REV Driver Hub just "Driver Hub" consistently for the future.
|
||
There are 2 methods to update the DS app on a DS phone: | ||
|
||
1. REV Hardware Client (RHC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want these #'s indented to the same indent as the #'s above?
:width: 80% | ||
:align: center | ||
|
||
Updating the Driver Hub | ||
Update Status of Phone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smartphone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments in the files. Looks great overall. A major improvement.
The Game Manual Part 1 allows USB Video Class (UVC) cameras for | ||
robot vision tasks. If you are using a REV Robotics Control Hub, then | ||
The Competition Manual allows the use of USB Video Class (UVC) compatible | ||
cameras for computer vision-related tasks. See rule R715 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove reference to a specific rule
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Elizabeth.
Rephrase to not point to s specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
@miriamsr @WestsideRobotics I've gone through each file with a few comments. I think the removal of rules can wait until next season. As long as Chris agrees let's approve! |
This document describes how to connect and configure an additional Expansion | ||
Hub for use in the FIRST Tech Challenge. Note that the FIRST Tech Challenge | ||
Competition Manual limits the maximum number of Control or Expansion Hubs on | ||
a single robot to two. See rule R701 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to s specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
@@ -54,22 +39,123 @@ need the following items: | |||
- .. figure:: images/TamiyaAdapter.jpg | |||
|
|||
* - FIRST-approved 12V Battery (such as Tetrix W39057). For a list of | |||
FIRST-approved 12V batteries, refer to the current Game Manual | |||
Part 1, rule <RE03>. | |||
FIRST-approved 12V batteries, refer to the current Competition Manual, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to s specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
|
||
* - A FIRST-approved Android smartphone with the FTC Robot Controller | ||
app installed. For a list of FIRST-approved Android smartphones, | ||
refer to the current Competition Manual, rule R704. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to s specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
**Important Note:** While scrcpy is a great way to view the camera output | ||
outside of competitions, the Competition Manual does now allow teams to | ||
have any devices other than the DRIVER STATION connected to your Control | ||
Hub during a match. See rule R708 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
connected camera instead of the Android smartphone’s built-in camera for | ||
computer vision tasks. | ||
The Competition Manual allows the use of USB Video Class (UVC) compatible | ||
cameras for computer vision-related tasks. See rule R715 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
this connection. If a team uses a powered USB hub, the power to operate | ||
the USB hub can only come from either of the following sources: | ||
Also note that the Competition Manual permits the use of a powered USB | ||
hub to make this connection. See rule R617 for the full details. If a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
|
||
1. An externally connected USB 5V Battery Pack. | ||
1. An externally connected COTS USB Battery Pack in compliance with the | ||
Competition Manual. See rule R602 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
@@ -55,7 +62,7 @@ smartphone for use as an DRIVER STATION. The process is as follows, | |||
Renaming Your Smartphones | |||
~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|||
The official rules of the *FIRST* Tech Challenge (see <RS01>) require that | |||
The official rules of the *FIRST* Tech Challenge (see R707) require that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
* - A REV Robotics Control Hub to be used as a ROBOT CONTROLLER. | ||
Alternately, the Competition Manual does allow teams to instead | ||
use a REV Robotics Expansion Hub and a select list of Android | ||
phones. See rules R701 and R704 for the full details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Suggest something like:
Check the Robot Construction rules in the Competition Manual for details.
|
||
* - A REV Robotics Driver Hub to be used as a DRIVER STATION device. | ||
Alternately, the Competition Manual does allow teams to instead | ||
us a select list of Android phones. See rule R901 for the full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
~~~~~~~~~~~~~~~~~~ | ||
|
||
While not recommended, the Competition Manual does allow select Android | ||
smartphones to be used as a DRIVER STATION or ROBOT CONTROLLER. See rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase to not point to a specific rule number. Rule numbers may shift year to year.
Resolves FIRST-Tech-Challenge/ftcdocs-private#106