Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-emphasizing phones #294

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

miriamsr
Copy link
Member

@miriamsr miriamsr commented Aug 2, 2024

Resolves FIRST-Tech-Challenge/ftcdocs-private#106

@emcclurg
Copy link
Contributor

emcclurg commented Aug 2, 2024

This looks good to me. T

@uvidyadharan uvidyadharan marked this pull request as draft August 2, 2024 17:26
@emcclurg emcclurg marked this pull request as ready for review August 16, 2024 14:20
@emcclurg
Copy link
Contributor

@miriamsr will you be able to finish this by next week?

@miriamsr
Copy link
Member Author

@emcclurg Yes, I will get back to work on this, end of next week should be doable.

@emcclurg emcclurg self-requested a review December 18, 2024 19:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily rn but we may want to call the REV Driver Hub just "Driver Hub" consistently for the future.


There are 2 methods to update the DS app on a DS phone:

1. REV Hardware Client (RHC)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want these #'s indented to the same indent as the #'s above?

:width: 80%
:align: center

Updating the Driver Hub
Update Status of Phone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smartphone

Copy link
Contributor

@emcclurg emcclurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments in the files. Looks great overall. A major improvement.

The Game Manual Part 1 allows USB Video Class (UVC) cameras for
robot vision tasks. If you are using a REV Robotics Control Hub, then
The Competition Manual allows the use of USB Video Class (UVC) compatible
cameras for computer vision-related tasks. See rule R715 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove reference to a specific rule

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Elizabeth.

Rephrase to not point to s specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

@emcclurg
Copy link
Contributor

@miriamsr @WestsideRobotics I've gone through each file with a few comments. I think the removal of rules can wait until next season. As long as Chris agrees let's approve!

This document describes how to connect and configure an additional Expansion
Hub for use in the FIRST Tech Challenge. Note that the FIRST Tech Challenge
Competition Manual limits the maximum number of Control or Expansion Hubs on
a single robot to two. See rule R701 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to s specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

@@ -54,22 +39,123 @@ need the following items:
- .. figure:: images/TamiyaAdapter.jpg

* - FIRST-approved 12V Battery (such as Tetrix W39057). For a list of
FIRST-approved 12V batteries, refer to the current Game Manual
Part 1, rule <RE03>.
FIRST-approved 12V batteries, refer to the current Competition Manual,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to s specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.


* - A FIRST-approved Android smartphone with the FTC Robot Controller
app installed. For a list of FIRST-approved Android smartphones,
refer to the current Competition Manual, rule R704.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to s specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

**Important Note:** While scrcpy is a great way to view the camera output
outside of competitions, the Competition Manual does now allow teams to
have any devices other than the DRIVER STATION connected to your Control
Hub during a match. See rule R708 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

connected camera instead of the Android smartphone’s built-in camera for
computer vision tasks.
The Competition Manual allows the use of USB Video Class (UVC) compatible
cameras for computer vision-related tasks. See rule R715 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

this connection. If a team uses a powered USB hub, the power to operate
the USB hub can only come from either of the following sources:
Also note that the Competition Manual permits the use of a powered USB
hub to make this connection. See rule R617 for the full details. If a
Copy link
Contributor

@rachmo rachmo Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.


1. An externally connected USB 5V Battery Pack.
1. An externally connected COTS USB Battery Pack in compliance with the
Competition Manual. See rule R602 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

@@ -55,7 +62,7 @@ smartphone for use as an DRIVER STATION. The process is as follows,
Renaming Your Smartphones
~~~~~~~~~~~~~~~~~~~~~~~~~

The official rules of the *FIRST* Tech Challenge (see <RS01>) require that
The official rules of the *FIRST* Tech Challenge (see R707) require that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.

* - A REV Robotics Control Hub to be used as a ROBOT CONTROLLER.
Alternately, the Competition Manual does allow teams to instead
use a REV Robotics Expansion Hub and a select list of Android
phones. See rules R701 and R704 for the full details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Suggest something like:

Check the Robot Construction rules in the Competition Manual for details.


* - A REV Robotics Driver Hub to be used as a DRIVER STATION device.
Alternately, the Competition Manual does allow teams to instead
us a select list of Android phones. See rule R901 for the full
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

~~~~~~~~~~~~~~~~~~

While not recommended, the Competition Manual does allow select Android
smartphones to be used as a DRIVER STATION or ROBOT CONTROLLER. See rule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to not point to a specific rule number. Rule numbers may shift year to year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants