Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ts and tsx extensions #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include ts and tsx extensions #2

wants to merge 1 commit into from

Conversation

renemn
Copy link

@renemn renemn commented Nov 6, 2018

CRA added Typescript support, this ensures ts and tsx estensions are included.
Resolves issue #1

The test follows the same pattern as in CRA's webpack config file: CRA test

F1LT3R
F1LT3R requested changes Nov 6, 2018
View reviewed changes
Copy link
Owner

@F1LT3R F1LT3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a check for an array of values here?

@StepanDyubin StepanDyubin mentioned this pull request Apr 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F1LT3R F1LT3R F1LT3R requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renemn @F1LT3R