Add setup screen #470
Add setup screen #470
Conversation
…ea/dataset-configuration into feature/setup-screen
i18n/es.po
Outdated
| msgid "and {{number}} more." | ||
| msgstr "" | ||
|
|
||
| #, fuzzy |
There was a problem hiding this comment.
Remove fuzzy comments (check all the files)
| // const projectAttributeId = attributes.project.id; | ||
| // const projectAttribute = existingAttributes?.find( | ||
| // attribute => attribute.attribute.id === projectAttributeId | ||
| // ); |
| // attribute => attribute.attribute.id === projectAttributeId | ||
| // ); | ||
|
|
||
| const pa = { attribute: { id: attributes.project.id }, value: dataSet.project?.id }; |
There was a problem hiding this comment.
pa -> more declarative name
| const createdByAttribute = { attribute: { id: attributes.createdByApp.id }, value: "true" }; | ||
|
|
||
| const attributesToSave = _([pa, createdByAttribute]) | ||
| .compactMap(attribute => (attribute.value ? attribute : undefined)) |
| attr => !attributesToSave.some(save => save.attribute.id === attr.attribute.id) | ||
| ) || []; | ||
|
|
||
| // Combinar `filteredExisting` con `toSave` |
| }); | ||
| } | ||
| } | ||
| export type ValidateNameOptions = { name: string; dataSetId: Id }; |
There was a problem hiding this comment.
name/dataSetId, both should contain "dataSet" (or none). I'd change all the naming of the use case/types: ValidateNameUseCase -> ValidateDataSetNameUseCase.
| return Promise.resolve(getErrors(result.value.error)); | ||
| } | ||
| } | ||
| return Promise.resolve([]); |
| return Promise.resolve([]); | ||
| }, | ||
| [dataSet, validationInProgressOrError] | ||
| ); |
There was a problem hiding this comment.
Too long. The validation stuff can be moved to a custom hook.
| expiryDays: 0, | ||
| openFuturePeriods: 0, | ||
| notifyUser: false, | ||
| }); |
There was a problem hiding this comment.
Maybe move to DataSet.initial() ?
| return { dataSet, status, updateDataSet }; | ||
| } | ||
|
|
||
| export type HttpStatus = "idle" | "loading" | "finished" | "error"; |
There was a problem hiding this comment.
not important, but it looks a bit weird :) Maybe RequestStatus, LoadingStatus or similar.
| ), | ||
| }); | ||
| }); | ||
| return this.getCategoryOptionsByCode(categories.project.code).map(d2Response => { |
There was a problem hiding this comment.
Typically, we'd make getCategoryOptionsByCode return directly the categoryOptions, no need for the full response. It's a way of narrowing scopes.
📌 References
📝 Implementation
I'm going to create a PR for every step in the wizard in order to avoid a long and complex testing process.
📹 Screenshots/Screen capture
Project-Configuration-app_create_dataset.webm
🔥 Notes to the tester