fix: close response body in mapping functions #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
We've noticed that HTTP responses are not closed properly in some places where we do the Request/Response mappings for OkHttp and Apollo Clients.
Task
Ensure that original responses coming from
OkHttp
andApolloClient
are closed properly after mapping from/to SDK HTTP models.Action
use()
function in all response body mapping functions.use()
ensures that the consumed resource is closed by callingclose()
function automatically.Testing
All existing and new tests are passing ✅