fix: Remove update_infra from Expedia provider

ExpediaGroup · Oct 30, 2024 · 635236e · 635236e
1 parent 22bcbc4
commit 635236e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/sdk/python/feast/expediagroup/provider/expedia.py b/sdk/python/feast/expediagroup/provider/expedia.py
@@ -59,27 +59,3 @@ def ingest_df(
             )
 
         super().ingest_df(feature_view, df.drop(drop_list, axis=1))
-
-    def update_infra(
-        self,
-        project: str,
-        tables_to_delete: Sequence[FeatureView],
-        tables_to_keep: Sequence[FeatureView],
-        entities_to_delete: Sequence[Entity],
-        entities_to_keep: Sequence[Entity],
-        partial: bool,
-    ):
-        if self.online_store:
-            if tables_to_delete:
-                logger.info(
-                    f"Data associated to {[feature_view.name for feature_view in tables_to_delete]} feature views will be deleted from the online store based on ttl defined if the entities are not shared with other feature views"
-                )
-
-        if self.batch_engine:
-            self.batch_engine.update(
-                project,
-                tables_to_delete,
-                tables_to_keep,
-                entities_to_delete,
-                entities_to_keep,
-            )
diff --git a/sdk/python/feast/repo_config.py b/sdk/python/feast/repo_config.py
@@ -243,6 +243,8 @@ def __init__(self, **data: Any):
         self._online_store = None
         if provider == "expedia":
             self.online_config = data.get("online_store", "redis")
+            if self.online_config["type"] == "redis":
+                self.online_config["full_scan_for_deletion"] = True
         else:
             self.online_config = data.get("online_store", "sqlite")