Skip to content

Commit

Permalink
fix: Adding min required protobuf version (#142)
Browse files Browse the repository at this point in the history
Co-authored-by: Bhargav Dodla <[email protected]>
  • Loading branch information
EXPEbdodla and Bhargav Dodla authored Oct 14, 2024
1 parent d2d4ffd commit 0020c2e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ install-python-ci-dependencies-uv-venv:
python setup.py build_python_protos --inplace

install-protoc-dependencies:
pip install "protobuf<5" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"
pip install "protobuf>=4.24.0,<5.0.0" "grpcio-tools>=1.56.2,<2" "mypy-protobuf>=3.1"

lock-python-ci-dependencies:
uv pip compile --system --no-strip-extras setup.py --extra ci --output-file sdk/python/requirements/py$(PYTHON_VERSION)-ci-requirements.txt
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build-system]
requires = [
"protobuf<5",
"protobuf>=4.24.0,<5.0.0",
"grpcio-tools>=1.56.2,<2",
"mypy-protobuf>=3.1",
"pybindgen==0.22.0",
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"click>=7.0.0,<9.0.0",
"colorama>=0.3.9,<1",
"dill~=0.3.0",
"protobuf<5",
"protobuf>=4.24.0,<5.0.0",
"Jinja2>=2,<4",
"jsonschema",
"mmh3",
Expand Down Expand Up @@ -170,7 +170,7 @@
"virtualenv==20.23.0",
"cryptography>=35.0,<43",
"ruff>=0.3.3",
"protobuf<5",
"protobuf>=4.24.0,<5.0.0",
"mypy-protobuf>=3.1",
"grpcio-tools>=1.56.2,<2",
"grpcio-testing>=1.56.2,<2",
Expand Down Expand Up @@ -505,7 +505,7 @@ def run(self):
setup_requires=[
# snowflake udf packages refer to conda packages, not pypi libraries. Conda stack is still on protobuf 4
# So we are adding protobuf<5 as a requirement
"protobuf<5",
"protobuf>=4.24.0,<5.0.0",
"grpcio-tools>=1.56.2,<2",
"mypy-protobuf>=3.1",
"pybindgen==0.22.0",
Expand Down

0 comments on commit 0020c2e

Please sign in to comment.