chore: relax the defaults to include logger only. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
commented
Feb 4, 2020
| @@ -3,52 +3,8 @@ agents { | |||
| enabled = true | |||
| port = 35000 | |||
| dispatchers { | |||
There was a problem hiding this comment.
From @worldtiki:
if these are disabled does it make sense to completely remove these blocks?
if you need to enable one it will force you to declare all of these properties (ie, we lose the defaults).
There was a problem hiding this comment.
Ignore that comment please :)
I was not aware that the defaults were baked in the code for each of the dispatchers.
jcchavezs
force-pushed
the
relax_defaults
branch
from
d87a1fa to
6668b4e
Compare
jcchavezs
force-pushed
the
relax_defaults
branch
from
6668b4e to
da60199
Compare
jcchavezs
commented
Feb 4, 2020
| your micro service is running. One needs to add the haystack | ||
| [client library](https://github.com/ExpediaDotCom/haystack-client-java) in the application to push the spans to the agent and [haystack-blobs](https://github.com/ExpediaDotCom/blobs/tree/master/haystack-blobs) library to push blobs to the agent. | ||
| your micro service is running. One needs to add the haystack | ||
| [client libraries](https://github.com/ExpediaDotCom?q=haystack-client) in the application to push the spans to the agent and [haystack-blobs](https://github.com/ExpediaDotCom/blobs/tree/master/haystack-blobs) library to push blobs to the agent. |
There was a problem hiding this comment.
We open possibilities for more languages.
keshavpeswani
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relax the defaults, using logger.
Closes #80 #78
Ping @keshavpeswani @ashishagg @worldtiki