Reconnection ws connection when it is closed

[leonz789]

Summary by CodeRabbit

Release Notes

• Improvements

  • Enhanced retry mechanism for initializing client connections
  • Optimized WebSocket connection handling
  • Improved error management for client initialization

• Changes

  • Increased maximum retry attempts for client connections
  • Simplified WebSocket connection logic
  • Updated method signatures for better state management

• Performance

  • Reduced interval between connection retry attempts
  • More robust connection handling under adverse network conditions

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications across three files: cmd/feeder_debug.go, exoclient/client.go, and exoclient/subscribe.go. The changes primarily focus on enhancing WebSocket connection handling, retry mechanisms, and improving code clarity. Key modifications include increasing retry attempts for debug configurations, simplifying WebSocket connection logic, and refactoring method signatures to use pointer receivers for better state management.

Changes

File	Change Summary
cmd/feeder_debug.go	- Increased MaxAttempts from 10 to 43200 - Reduced retry Interval from 3 to 2 seconds
exoclient/client.go	- Removed WebSocket connection logic when txOnly is true
exoclient/subscribe.go	- Updated method signatures to use pointer receivers - Renamed increaseWsRountines to increaseWsRoutines - Refined WebSocket routine management - Simplified subscription initialization

Sequence Diagram

sequenceDiagram
    participant Feeder as Debug Price Feeder
    participant Client as ExoClient
    participant WS as WebSocket

    Feeder->>Client: Initialize with retry config
    Client->>WS: Attempt Connection
    alt txOnly is false
        WS-->>Client: Establish Connection
        Client-->>Feeder: Connection Successful
    else txOnly is true
        Client-->>Feeder: Skip WebSocket Connection
    end

Loading

Possibly related PRs

• Feat/params update #11: Improvements in feeder management and error handling, particularly related to parameter updates and retry mechanisms

Poem

🐰 Retry, retry, with rabbit might,
WebSocket dancing, connections bright!
From ten attempts to forty-three grand,
Our code now leaps across the land!
Connection magic, swift and clean,
A rabbit's code, forever keen! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7516de7 and 5afb53c.

📒 Files selected for processing (3)

• cmd/feeder_debug.go (2 hunks)
• exoclient/client.go (0 hunks)
• exoclient/subscribe.go (9 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.