Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:reconnecting ws when closed #14

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

leonz789
Copy link
Collaborator

@leonz789 leonz789 commented Dec 31, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced retry mechanism for price feeder initialization
    • Improved WebSocket connection management
  • Bug Fixes

    • Corrected method naming for WebSocket routines
    • Streamlined WebSocket connection handling
  • Refactor

    • Updated method receivers to support state modifications
    • Simplified WebSocket client initialization
    • Removed unnecessary comments and code

The release focuses on improving system reliability and connection robustness for the price feeder service.

Copy link

coderabbitai bot commented Dec 31, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to the price feeder's retry configuration, WebSocket client initialization, and subscription mechanisms. The changes primarily focus on enhancing the retry logic in the debug configuration, simplifying WebSocket connection establishment, and improving the WebSocket subscription method signatures. These modifications aim to increase the robustness and flexibility of the exoclient's connection and subscription handling.

Changes

File Change Summary
cmd/feeder_debug.go - Increased MaxAttempts from 10 to 43200
- Reduced retry Interval from 3s to 2s
- Updated getOracleParamsWithMaxRetry call
exoclient/client.go - Removed WebSocket connection logic when txOnly is true
- Simplified client initialization process
exoclient/subscribe.go - Changed method receivers from value to pointer
- Updated method signatures for various WebSocket-related methods
- Corrected method name typos (e.g., increaseWsRountinesincreaseWsRoutines)
- Modified Subscribe method control flow

Sequence Diagram

sequenceDiagram
    participant Feeder as Price Feeder
    participant Client as ExoClient
    participant WS as WebSocket

    Feeder->>Client: Initialize with retry config
    Client->>WS: Attempt WebSocket connection
    alt Connection Successful
        WS-->>Client: Connection established
        Client->>Feeder: Ready for subscriptions
    else Connection Failed
        Client--)Feeder: Retry connection (up to 43200 times)
    end
Loading

Poem

🐰 Retry, retry, with rabbit might,
WebSocket dancing through the night,
From ten attempts to forty-three grand,
Our connection leaps across the land!
With pointer magic and nimble grace,
We'll catch those signals in our embrace! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7516de7 and b0eb57a.

📒 Files selected for processing (3)
  • cmd/feeder_debug.go (2 hunks)
  • exoclient/client.go (0 hunks)
  • exoclient/subscribe.go (9 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leonz789 leonz789 merged commit 5afb53c into develop Dec 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant