Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button #158

Merged
merged 5 commits into from
May 30, 2024
Merged

Back button #158

merged 5 commits into from
May 30, 2024

Conversation

AnanyaJain25
Copy link
Contributor

Description

Adding Home icon and Back to home button in Game Rules Page #149

Motivation and Context

UI was missing back to home button once user goes to gamerules page.

How Has This Been Tested?

Changes can be directly seen on browser.

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots (if necessary):

Screenshot 2024-05-30 102737
Screenshot 2024-05-30 102753

Copy link

netlify bot commented May 30, 2024

Deploy Preview for eternalgameoflife ready!

Name Link
🔨 Latest commit af416e6
🔍 Latest deploy log https://app.netlify.com/sites/eternalgameoflife/deploys/665875c324ba7f0008712df6
😎 Deploy Preview https://deploy-preview-158--eternalgameoflife.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adityas-github
Copy link
Contributor

adityas-github commented May 30, 2024

Hey you can add home icon to left corner as it provides better user experience.

@AnanyaJain25
Copy link
Contributor Author

Hey you can add home icon to left corner as it provides better user experience.

sure sir

@AnanyaJain25
Copy link
Contributor Author

AnanyaJain25 commented May 30, 2024

@adityas-github is this fine?
Screenshot 2024-05-30 175757

@EternoSeeker
Copy link
Owner

@AnanyaJain25 yes it's fine, can you please look into the conflicts, then I can merge, thank you

@EternoSeeker EternoSeeker merged commit 6aac9d3 into EternoSeeker:main May 30, 2024
4 checks passed
@EternoSeeker
Copy link
Owner

thank you @AnanyaJain25

@EternoSeeker EternoSeeker added the gssoc GirlScript Summer of Code 2024 label May 30, 2024
@EternoSeeker EternoSeeker added the level1 GSSoC - Easy to tackle label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GirlScript Summer of Code 2024 level1 GSSoC - Easy to tackle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants