WIP: hotshot 0.5.83 #2417
Merged
WIP: hotshot 0.5.83 #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make rustc happy. - Still contains some todo!. - `cargo check` passes - `cargo check --tests` fails, needs a fix in query service
1 task
Tests also compile now (with some holes in builder initialization)
sveitser
commented
Dec 19, 2024
Since we have a crate that depends on the main workspace now the cargo patches don't affect it and compilation fails as a result.
sveitser
commented
Dec 19, 2024
Run `cargo update` and add some fixes for recent updates. We need `add_epoch_root()` on `Memberships` trait to fix this.
Hotshot now has a new function update_next_epoch_high_qc2() in its storage trait to update the next epoch qc in persistence. This PR adds storage for this quorum certificate and also loads it when loading the consensus data,
Remove check for `drb_seed`
Remove epoch height constant
These now have default implementations in the trait
Fix storage method recursion
imabdulbasit
requested review from
philippecamacho,
ImJeremyHe,
jbearer and
tbro
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is currently into branch
ab/stnot intomain.cargo checkpassescargo check --testspassesTODO
migrate_consensus(ed6c822)