2372 stake table add tests to the withdrawfunds function #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions that need to be updated to the new spec
…ey. todo: add tests
…ate-validator-identification-keys
…nclusion of the blsKey
… account the validator registered with
…lsVK comparison to field by field comparison so that it is more efficient and more obvious what is going on
…hat have been commented out for now
…um address, update related implementations and add tests
…nto 2372-stake-table-add-tests-to-the-withdrawfunds-function
… function until epochs are implemented, removed unecessary checks from the withdrawFunds function
alysiahuggins
requested review from
philippecamacho,
ImJeremyHe and
sveitser
as code owners
alysiahuggins
requested review from
jbearer,
tbro and
imabdulbasit
as code owners
alysiahuggins
deleted the
2372-stake-table-add-tests-to-the-withdrawfunds-function
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2372
This PR:
This PR does not:
Key places to review:
withdrawFunds()function and its related testsHow to test this PR:
forge test --match-contract StakeTable