Update v0_1::ChainConfig::from(v0_3::ChainConfig)
#1886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
committable
version in sequencer and use it to coerce a v3 Commitment into a v1 commitment.This PR:
This removes a best effort (and untested) downgrade of ChainConfig commitment in favor of using raw bytes (recently added to
committable
). Previously a v1ResolvableChainConfig
was derived from a v3 version using a a full cycle of serialization/de-serialization. Now that we can create a Commitment from some bytes, we can avoid that extra work. Some tests have been added to confirm expectations.Key places to review: